Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1869886: Fix to configure vmxnet3 driver in multicast mode #2007

Merged
merged 1 commit into from Aug 26, 2020
Merged

Bug 1869886: Fix to configure vmxnet3 driver in multicast mode #2007

merged 1 commit into from Aug 26, 2020

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Aug 18, 2020

When the vmxnet3 driver gets added to ovs, it does not
honor the promiscuous mode setting for multicast traffic.
This PR adds support to temporarily fix that by configuring
the allmulti flag on the interface when it's moved to ovs.

@abhat
Copy link
Contributor Author

abhat commented Aug 18, 2020

/assign @trozet

@kikisdeliveryservice kikisdeliveryservice requested review from kikisdeliveryservice and removed request for cgwalters August 18, 2020 19:59
@kikisdeliveryservice
Copy link
Contributor

@abhat please add a BZ to this PR

/hold

@kikisdeliveryservice kikisdeliveryservice added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020
@trozet
Copy link
Contributor

trozet commented Aug 18, 2020

@kikisdeliveryservice this is a workaround until the driver is actually fixed in the kernel, which is being tracked by:
https://bugzilla.redhat.com/show_bug.cgi?id=1854355

@abhat we should probably have a more clear comment in the code with "REMOVEME" or something after the fix is done

I didn't see a BZ mentioned in a PR that touched this code yesterday:
#2006

Is it ok to not include one for this workaround?

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Aug 18, 2020 •
edited

I didn't see a BZ mentioned in a PR that touched this code yesterday:
#2006

Is it ok to not include one for this workaround?

That PR should have had a BZ as well. Please make one so we can track these changes as we are well past codefreeze. As this is a fix for something not currently working correctly we should have a BZ articulating the issue so that the workaround can be verified.

@abhat abhat changed the title Fix to configure vmxnet3 driver in multicast mode Bug: 1869886 Fix to configure vmxnet3 driver in multicast mode Aug 18, 2020
@kikisdeliveryservice kikisdeliveryservice changed the title Bug: 1869886 Fix to configure vmxnet3 driver in multicast mode Bug 1869886: Fix to configure vmxnet3 driver in multicast mode Aug 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 18, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1869886, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1869886: Fix to configure vmxnet3 driver in multicast mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references Bugzilla bug 1869886, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020
@abhat
Copy link
Contributor Author

abhat commented Aug 19, 2020

/test e2e-aws
/test e2e-aws-workers-rhel7

@abhat
Copy link
Contributor Author

abhat commented Aug 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1869886, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Aug 19, 2020

/test e2e-vsphere

@abhat
Copy link
Contributor Author

abhat commented Aug 19, 2020

/test e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@abhat: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test cluster-bootimages
  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-gcp-op
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test images
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-gcp-upgrade
  • /test okd-images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify

In response to this:

/test e2e-vsphere-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Fix to configure vmxnet3 driver in multicast mode
414a222 
When the vmxnet3 driver gets added to ovs, it does not
honor the promiscuous mode setting for multicast traffic.
This PR adds support to temporarily fix that by configuring
the allmulti flag on the interface when it's moved to ovs
trozet
trozet approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@trozet
Copy link
Contributor

trozet commented Aug 20, 2020

@runcom @kikisdeliveryservice PTAL

@abhat
Copy link
Contributor Author

abhat commented Aug 21, 2020

/test e2e-aws-workers-rhel7

@abhat
Copy link
Contributor Author

abhat commented Aug 21, 2020

/test e2e-aws

@abhat
Copy link
Contributor Author

abhat commented Aug 21, 2020

@runcom @kikisdeliveryservice can one of you PTAL and approve as appropriate?

@runcom
Copy link
Member

runcom commented Aug 24, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, runcom, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@yuqi-zhang
Copy link
Contributor

This shouldn't affect AWS and I don't know how to personally verify this, but if you're confident it works I am LGTM in terms of the code

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@abhat: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 8796eabd5b34c6bd0eac795bc6cc6716a6f3fc5d link /test e2e-vsphere
ci/prow/okd-e2e-aws 414a222 link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit afc9074 into openshift:master Aug 26, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: All pull requests linked via external trackers have merged:

Bugzilla bug 1869886 has been moved to the MODIFIED state.

In response to this:

Bug 1869886: Fix to configure vmxnet3 driver in multicast mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@abhat @kikisdeliveryservice @trozet @openshift-ci-robot @runcom @yuqi-zhang @openshift-bot @openshift-merge-robot