Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[baremetal] Create and enable overlay mount point for NetworkManager #2017

Merged
merged 1 commit into from Nov 1, 2020
Merged

[baremetal] Create and enable overlay mount point for NetworkManager #2017

merged 1 commit into from Nov 1, 2020

Conversation

bcrochet
Copy link
Member

@bcrochet bcrochet commented Aug 20, 2020 •
edited

This does 4 things for the baremetal platform:

  1. Configures NetworkManager to look for it's keyfiles in /etc/NetworkManager/system-connections-merged
  2. Creates that directory
  3. Adds two temporary directories for systemd-tmpfiles to process. These are the storage and work locations for the overlay.
  4. Mount an overlay filesystem at /etc/NetworkManager/system-connections-merged that uses /etc/NetworkManager/system-connections as the lower filesystem, and the temporary directory as the upper.

Any changes made outside of a MachineConfig will result in it being ephemeral. This maintains the idea that MCO will own the configuration of a machine before kubelet runs. MCO changes would go into /etc/NetworkManager/system-connections.

- What I did

- How to verify it

- Description for the changelog

Mount an overlay directory to make NetworkManager changes ephemeral.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2020
@cybertron
Copy link
Member

MCO looks unhappy with this:

lstat /etc/NetworkManager/system-connections-merged/.dummy: no such file or directory

@bcrochet
Copy link
Member Author

MCO looks unhappy with this:

lstat /etc/NetworkManager/system-connections-merged/.dummy: no such file or directory

Thanks. I'll take a look at that.

@bcrochet
Copy link
Member Author

/retitle [baremetal] Create and enable overlay mount point for NetworkManager

@openshift-ci-robot openshift-ci-robot changed the title [WIP][baremetal] Create and enable overlay mount point for Network Manager [baremetal] Create and enable overlay mount point for NetworkManager Aug 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2020
@bcrochet
Copy link
Member Author

/retest

@bcrochet
[baremetal] Create and enable overlay mount point for Network Manager
6666e7f 
This does 4 things for the baremetal platform:

1. Configures NetworkManager to look for it's keyfiles in /etc/NetworkManager/system-connections-merged
2. Creates that directory
3. Adds two temporary directories for systemd-tmpfiles to process. These are the storage and work locations for the overlay.
4. Mount an overlay filesystem at /etc/NetworkManager/system-connections-merged that uses /etc/NetworkManager/system-connections as the lower filesystem, and the temporary directory as the upper.

Any changes made outside of a MachineConfig will result in it being ephemeral. This maintains the idea that MCO will own the configuration of a machine before kubelet runs.
@bcrochet
Copy link
Member Author

bcrochet commented Sep 2, 2020

Implementation of Option C in openshift/enhancements#399

@bcrochet bcrochet mentioned this pull request Sep 9, 2020
Merged
@bcrochet
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

@bcrochet: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 6666e7f link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bcrochet
Copy link
Member Author

/retest

1 similar comment
@bcrochet
Copy link
Member Author

/retest

@cybertron
Copy link
Member

/lgtm

Looks like all of the comments have been addressed and it's passing ci.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@sinnykumari
Copy link
Contributor

lgtm, implements what has been described in openshift/enhancements#399 in Option C
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, cybertron, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bcrochet
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

18 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3aac39f into openshift:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters left review comments

@celebdor celebdor celebdor left review comments

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@cybertron cybertron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bcrochet @cybertron @openshift-ci-robot @sinnykumari @openshift-bot @cgwalters @celebdor @openshift-merge-robot