Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed #2039

Closed

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Aug 30, 2020

When OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP deployment configuration parameter is set to true the bootstrap node won't be destroyed and the infrastructure components (e.g: Keepalived) on the bootstrap continue to run.

This PR verifies that Keepalived instance on the bootstrap node is shutdown after bootstrap complete phase, this change is important for platforms that run Keepalived in unicast mode (baremetal).

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yboaron
To complete the pull request process, please assign runcom
You can assign the PR to them by writing /assign @runcom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yboaron
Copy link
Contributor Author

yboaron commented Aug 30, 2020

/retitle bug1866265 : [baremetal] Stop keepalived on bootstrap after bootstrap completed

@openshift-ci-robot openshift-ci-robot changed the title [baremetal] Stop keepalived on bootstrap after bootstrap completed bug1866265 : [baremetal] Stop keepalived on bootstrap after bootstrap completed Aug 30, 2020
@yboaron
Copy link
Contributor Author

yboaron commented Aug 30, 2020

/retitle bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed

@openshift-ci-robot openshift-ci-robot changed the title bug1866265 : [baremetal] Stop keepalived on bootstrap after bootstrap completed bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed Aug 30, 2020
@yboaron yboaron force-pushed the stop_keepalived_on_bootstrap branch 2 times, most recently from 01075b7 to 7b772bf Compare August 30, 2020 15:20
When OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP deployment configuration parameter is set to true
the bootstrap node won't be destroyed and infrastructure components (e.g: Keepalived) on the bootstrap continue to run.
This PR verifies that Keepalived instance on the bootstrap node is shutdown after bootstrap complete phase.
@yboaron yboaron force-pushed the stop_keepalived_on_bootstrap branch from 7b772bf to bf28498 Compare August 30, 2020 17:25
@yboaron
Copy link
Contributor Author

yboaron commented Aug 30, 2020

/retitle [WIP] bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed

@openshift-ci-robot openshift-ci-robot changed the title bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed [WIP] bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed Aug 30, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2020
@yboaron
Copy link
Contributor Author

yboaron commented Aug 30, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 30, 2020

@yboaron: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-step-registry bf28498 link /test e2e-ovn-step-registry
ci/prow/okd-e2e-aws bf28498 link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yboaron
Copy link
Contributor Author

yboaron commented Aug 31, 2020

/close
It's implemented by :
#2040 and
openshift/baremetal-runtimecfg#92

@openshift-ci-robot
Copy link
Contributor

@yboaron: Closed this PR.

In response to this:

/close
It's implemented by :
#2040 and
openshift/baremetal-runtimecfg#92

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants