-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed #2039
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yboaron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle bug1866265 : [baremetal] Stop keepalived on bootstrap after bootstrap completed |
/retitle bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed |
01075b7
to
7b772bf
Compare
When OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP deployment configuration parameter is set to true the bootstrap node won't be destroyed and infrastructure components (e.g: Keepalived) on the bootstrap continue to run. This PR verifies that Keepalived instance on the bootstrap node is shutdown after bootstrap complete phase.
7b772bf
to
bf28498
Compare
/retitle [WIP] bug: 1866265 [baremetal] Stop keepalived on bootstrap after bootstrap completed |
/retest |
@yboaron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close |
@yboaron: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP deployment configuration parameter is set to true the bootstrap node won't be destroyed and the infrastructure components (e.g: Keepalived) on the bootstrap continue to run.
This PR verifies that Keepalived instance on the bootstrap node is shutdown after bootstrap complete phase, this change is important for platforms that run Keepalived in unicast mode (baremetal).