Bug 1849543: Use mc name as finalizer for kubelet config #2076
Conversation
The uid was being used as the entry for the finalizer list but everytime an update happens it generates a new uid, which is why we were ending up with multiple uids in the finalizers list. So use the mc name for the list of finalizer instead as the mc name stays the same for each kubelet config. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@umohnani8: This pull request references Bugzilla bug 1849543, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@rphillips @yuqi-zhang PTAL |
|
Nice! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, umohnani8, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@umohnani8: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@umohnani8: All pull requests linked via external trackers have merged: Bugzilla bug 1849543 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@umohnani8: new pull request created: #2150 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1849543 (https://bugzilla.redhat.com/show_bug.cgi?id=1849543)
Signed-off-by: Urvashi Mohnani umohnani@redhat.com
- What I did
The uid was being used as the entry for the finalizer list
but everytime an update happens it generates a new uid, which
is why we were ending up with multiple uids in the finalizers
list. So use the mc name for the list of finalizer instead as
the mc name stays the same for each kubelet config.
- How to verify it
- Description for the changelog
Use MC name for the list of finalizers to avoid duplicate and multiple entries for the same MCP