Bug 1882209: baremetal & friends: Set coredns forward policy to sequential #2122
Conversation
|
@cybertron: This pull request references Bugzilla bug 1882209, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
openshift-ci-robot
requested review from
kikisdeliveryservice and
sinnykumari
cybertron
force-pushed
the
bm-forward-seq
branch
from
9b87c69
to
055033f
Compare
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-medium
|
@cybertron: This pull request references Bugzilla bug 1882209, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/test e2e-metal-ipi |
|
/assign @yboaron |
|
ping @cybertron |
cybertron
force-pushed
the
bm-forward-seq
branch
from
055033f
to
6bb900d
Compare
|
Sorry, I missed that this was in merge conflict. Should be ready to go now. |
|
This patch make sense for ovirt as well. Going to give a try. |
cybertron
force-pushed
the
bm-forward-seq
branch
from
6bb900d
to
cc3152d
Compare
This was already done for openstack in openshift#1527, but not for baremetal because we don't have any separation between external and internal hostnames. However, this behavior is unintuitive and we've found a number of instances where it has caused problems on the other platforms too. Switching the forward policy to sequential will avoid potentially confusing issues where a set of DNS servers works fine standalone but breaks when configured as the forwarding upstreams in coredns.
cybertron
force-pushed
the
bm-forward-seq
branch
from
cc3152d
to
0d7e44e
Compare
|
Okay, I've rebased this to pick up the dedupe changes and to apply it to the other on-prem platforms. It's causing confusing issues on all platforms. @mandre @rgolangh @jcpowermac @patrickdillon @bcrochet I think with this we can dedupe the corefile template too. I believe the only differences between them were this sequential change and whether they use the template or a db file. The latter is an implementation detail that yields effectively the same results so it shouldn't block us. Is anyone aware of any other differences I may have missed that would cause issues if we consolidated the coredns config? |
|
/test e2e-ovirt |
|
/retest |
OpenStack would be fine switching over to the on-prem template for corefile, at least I don't foresee any issue. |
|
Looks like the ovirt job has been red for nearly two weeks. It's unlikely that failure is related to this patch. |
|
tested in my lab, it seems resolved the issue reported on ovirt |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/retest |
|
Are any other sign offs needed based on the affected platforms? |
|
Maybe @jcpowermac or @patrickdillon . This is a pretty safe change though. It's just making coredns behave the same way the system resolver would. |
|
lgtm for kubevirt platform |
|
/retest |
|
Would be nice to merge this one soon. |
|
/assign @jcpowermac @patrickdillon PTAL /retest |
kikisdeliveryservice
changed the title
|
/lgtm |
|
@kikisdeliveryservice I think we have what we need to merge this now. |
|
just a friendly ping for the merge :) @mandre @kikisdeliveryservice |
|
@ashcrow, @cgwalters, @darkmuggle, @kikisdeliveryservice , @runcom , @sinnykumari , @yuqi-zhang anything pending for getting this in? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, dougsland, jcpowermac, sinnykumari, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws-serial |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: All pull requests linked via external trackers have merged: Bugzilla bug 1882209 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was already done for openstack in #1527, but not for baremetal
because we don't have any separation between external and internal
hostnames. However, in environments where the DNS servers are
misconfigured such that the second one listed in resolv.conf does
not properly resolve external names, this can cause intermittent
resolution failures from our coredns because it randomly chooses to
use the broken server.
Switching the forward policy to sequential will avoid potentially
confusing issues where a set of DNS servers works fine standalone
but breaks when configured as the forwarding upstreams in coredns.
- What I did
- How to verify it
- Description for the changelog