Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating ose-machine-config-operator builder & base images to be consistent with ART #2144

Merged
merged 1 commit into from Oct 23, 2020
Merged

Updating ose-machine-config-operator builder & base images to be consistent with ART #2144

merged 1 commit into from Oct 23, 2020

Conversation

jupierce
Copy link
Contributor

@jupierce jupierce commented Oct 7, 2020 •
edited

Updating ose-machine-config-operator builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/f66c03011773dc3755ad874fc691be612914d65f/images/ose-machine-config-operator.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

Depends on openshift/images#44 . Allow it to merge and then run /test all on this PR.

@jupierce jupierce force-pushed the art-consistency-openshift-4.7-ose-machine-config-operator branch from 0a3613c to 8c791c9 Compare October 7, 2020 15:57
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

@jupierce: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-op 0a3613c7b0aa12cb400a3d552697becb23d8d3e9 link /test e2e-gcp-op
ci/prow/e2e-upgrade 0a3613c7b0aa12cb400a3d552697becb23d8d3e9 link /test e2e-upgrade
ci/prow/e2e-aws 0a3613c7b0aa12cb400a3d552697becb23d8d3e9 link /test e2e-aws
ci/prow/okd-e2e-aws 0a3613c7b0aa12cb400a3d552697becb23d8d3e9 link /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7 0a3613c7b0aa12cb400a3d552697becb23d8d3e9 link /test e2e-aws-workers-rhel7
ci/prow/e2e-ovn-step-registry 0a3613c7b0aa12cb400a3d552697becb23d8d3e9 link /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

so holding lgtm until openshift/images#44 merges

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2020
@runcom
Copy link
Member

runcom commented Oct 22, 2020

/hold cancel
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, jupierce, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 23, 2020 •
edited

@jupierce: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-step-registry 8c791c9 link /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6c8bd9b into openshift:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jupierce @openshift-ci-robot @kikisdeliveryservice @runcom @openshift-bot @openshift-merge-robot @ashcrow