Bug 1887607: OVS config: check if OVS is installed #2164
Conversation
With UPI installs, openvswitch package is not installed until after upgrade. In the ovs-configuration.service there is a Requires declaration on openvswitch.service. However due to a bug in systemd, ovs-configuration is started even when openvswitch.service is not present: https://bugzilla.redhat.com/show_bug.cgi?id=1888017 As a workaround, this patch checks to ensure OVS is installed in configure-ovs.sh. Signed-off-by: Tim Rozet <trozet@redhat.com>
openshift-ci-robot
added
bugzilla/severity-urgent
|
@vrutkovs: This pull request references Bugzilla bug 1887607, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @trozet |
|
/retest |
|
/lgtm |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1887607, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1887607, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sdodson
added
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: trozet, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Patch manager, I've overridden the bugzilla/valid-bug flag because this is really only testable in 4.5 to 4.6 and I have personally tested that upgrade path with a release image built from this PR. This affects upgrade success in clusters with RHEL workers which is a small set but non zero. |
|
/refresh |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
OKD is currently broken on GCP (fix: #2160) /skip |
|
/bugzilla refresh |
|
@sdodson: This pull request references Bugzilla bug 1887607, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sdodson
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@vrutkovs: All pull requests linked via external trackers have merged: Bugzilla bug 1887607 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick of #2154 on 4.6
With UPI installs, openvswitch package is not installed until after
upgrade. In the ovs-configuration.service there is a Requires
declaration on openvswitch.service. However due to a bug in systemd,
ovs-configuration is started even when openvswitch.service is not
present:
https://bugzilla.redhat.com/show_bug.cgi?id=1888017
As a workaround, this patch checks to ensure OVS is installed in
configure-ovs.sh.
Signed-off-by: Tim Rozet trozet@redhat.com