crio: drop infra container when possible #2177
Conversation
in cri-o 1.19 we introduced a feature to drop the infra container when a pod doesn't have a pod level PID namespace We have been running with this option in cri-o internal tests and have seen no issues. Let's enable it by default in 4.7. In addition to being more performant, it also should aid in a race with the kubelet win-win! Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
We should do a few runs before merging this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@cgwalters The regular e2e test runs should catch regressions, if any. |
|
/retest |
|
We want to let this bake for a few runs in CI before merging, thus the hold. The e2e-agnostic-upgrade failed on a GCE error. |
|
/retest |
|
/test all |
|
hm doesn't look related |
|
/retest |
|
/test all |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/override ci/prow/okd-e2e-upgrade |
|
@cgwalters: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
- What I did
in cri-o 1.19 we introduced a feature to drop the infra container when a pod doesn't have a pod level PID namespace
We have been running with this option in cri-o internal tests and have seen no issues.
Let's enable it by default in 4.7. In addition to being more performant, it also should aid in a race with the kubelet
win-win!
Signed-off-by: Peter Hunt pehunt@redhat.com
- How to verify it
- Description for the changelog
Have CRI-O drop the infra container in some cases, which performs better