New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "crio: drop infra container when possible"" #2210
Revert "Revert "crio: drop infra container when possible"" #2210
Conversation
/hold |
a7999ca
to
6efb3cc
Compare
/retest |
6efb3cc
to
53c6d4e
Compare
/retest |
2 similar comments
/retest |
/retest |
53c6d4e
to
e1c68a3
Compare
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@haircommander is this is needed? |
yes! I recently had a patch that got into cri-o main branch that should solve the issues we're seeing. Gotta wait until cri-o 1.21 is pulled in though |
it is time /retest |
omg it's finally time?? you still want this hold? |
or at least I think it's time 😄 /hold cancel we still need aws-serial to pass. I am hoping it failed because the new cri-o isn't there yet, not because the new cri-o doesn't work /retest |
/retest |
e1c68a3
to
ce942cd
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
cri-o 1.21 is needed for this, which recently got yanked because it was a suspected cause of a promotion failure. I'll try this again next week |
remove when you're ready - thanks for the update 😸 /hold |
/retest |
fwiw, I ran |
ah, #2204 happened because MCO wasn't running e2e-aws-serial tests, and the original PR broke them. In conjunction with 2204, e2e-aws-serial tests were added to MCO, and this PR came soon after that revert+test add happened |
Gotcha - makes sense!! |
/approve |
/lgtm Holding for Sunday or Monday merge |
/retest |
@kikisdeliveryservice would you be so kind as to give the final approval? |
I've been waiting so long for this @haircommander 😆 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kikisdeliveryservice, mrunalp, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This reverts commit 4554713.
Attempt to drop infra container again, now with a test that verifies we don't regress in the same way that
caused us to revert before
Signed-off-by: Peter Hunt pehunt@redhat.com
- What I did
- How to verify it
- Description for the changelog