Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "crio: drop infra container when possible"" #2210

Merged
merged 1 commit into from Jul 19, 2021

Conversation

haircommander
Copy link
Member

This reverts commit 4554713.

Attempt to drop infra container again, now with a test that verifies we don't regress in the same way that
caused us to revert before

Signed-off-by: Peter Hunt pehunt@redhat.com

- What I did

- How to verify it

- Description for the changelog

@haircommander
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2020
@haircommander haircommander force-pushed the drop-infra-2 branch 2 times, most recently from a7999ca to 6efb3cc Compare November 19, 2020 17:16
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

2 similar comments
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

@openshift-merge-robot
Copy link
Contributor

@haircommander: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-step-registry e1c68a369a40d799864f7bdacf7084adda60e5e7 link /test e2e-ovn-step-registry
ci/prow/e2e-agnostic-upgrade e1c68a369a40d799864f7bdacf7084adda60e5e7 link /test e2e-agnostic-upgrade
ci/prow/e2e-aws-serial e1c68a369a40d799864f7bdacf7084adda60e5e7 link /test e2e-aws-serial
ci/prow/e2e-aws-workers-rhel7 e1c68a369a40d799864f7bdacf7084adda60e5e7 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

@haircommander is this is needed?

@haircommander
Copy link
Member Author

@haircommander is this is needed?

yes! I recently had a patch that got into cri-o main branch that should solve the issues we're seeing. Gotta wait until cri-o 1.21 is pulled in though

@haircommander
Copy link
Member Author

it is time

/retest

@kikisdeliveryservice
Copy link
Contributor

it is time

/retest

omg it's finally time?? you still want this hold?

@haircommander
Copy link
Member Author

or at least I think it's time 😄

/hold cancel

we still need aws-serial to pass. I am hoping it failed because the new cri-o isn't there yet, not because the new cri-o doesn't work

/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021
@haircommander
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander
To complete the pull request process, please assign yuqi-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member Author

/retest

@kikisdeliveryservice kikisdeliveryservice self-assigned this Feb 17, 2021
@haircommander
Copy link
Member Author

cri-o 1.21 is needed for this, which recently got yanked because it was a suspected cause of a promotion failure. I'll try this again next week

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 22, 2021

cri-o 1.21 is needed for this, which recently got yanked because it was a suspected cause of a promotion failure. I'll try this again next week

remove when you're ready - thanks for the update 😸

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

fwiw, I ran
test e2e-serial openshift/machine-config-operator#2210
with cluster-bot and it passed

@haircommander
Copy link
Member Author

ah, #2204 happened because MCO wasn't running e2e-aws-serial tests, and the original PR broke them. In conjunction with 2204, e2e-aws-serial tests were added to MCO, and this PR came soon after that revert+test add happened

@kikisdeliveryservice
Copy link
Contributor

ah, #2204 happened because MCO wasn't running e2e-aws-serial tests, and the original PR broke them. In conjunction with 2204, e2e-aws-serial tests were added to MCO, and this PR came soon after that revert+test add happened

Gotcha - makes sense!!

@kikisdeliveryservice
Copy link
Contributor

@mrunalp is this good to go in now? serial is passing and seems to make sense to merge now

/assign @mrunalp

@mrunalp
Copy link
Member

mrunalp commented Jul 16, 2021

/approve
Let's merge this on Monday

@rphillips
Copy link
Contributor

/lgtm
/hold

Holding for Sunday or Monday merge

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 16, 2021
@rphillips
Copy link
Contributor

/retest

@haircommander
Copy link
Member Author

@kikisdeliveryservice would you be so kind as to give the final approval?

@kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice would you be so kind as to give the final approval?

I've been waiting so long for this @haircommander 😆

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kikisdeliveryservice, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@haircommander
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 44989a2 link /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7 44989a2 link /test e2e-aws-workers-rhel7
ci/prow/e2e-metal-ipi 44989a2 link /test e2e-metal-ipi
ci/prow/e2e-aws-disruptive 44989a2 link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

/retest-required

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ab530b0 into openshift:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants