Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[on-prem] Move MDNS config file to common directory #2234

Merged
merged 1 commit into from Nov 20, 2020
Merged

[on-prem] Move MDNS config file to common directory #2234

merged 1 commit into from Nov 20, 2020

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Nov 17, 2020

Since etcd does not rely on DNS entries anymore,
there shouldn't be any difference between masters and workers MDNS configuration.

@yboaron
[on-prem] Use the same mdns config file for masters and workers nodes
0326570 
Since etcd does not rely on DNS entries anymore,
there shouldn't be any difference between masters and workers MDNS configuration.
@ashcrow ashcrow requested review from runcom and yuqi-zhang and removed request for ashcrow and kikisdeliveryservice November 17, 2020 14:57
mandre
mandre reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@yuqi-zhang
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, yboaron, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 19, 2020 •
edited

@yboaron: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 0326570 link /test okd-e2e-aws
ci/prow/e2e-ovn-step-registry 0326570 link /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f636365 into openshift:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@runcom runcom Awaiting requested review from runcom

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yboaron @yuqi-zhang @openshift-ci-robot @openshift-bot @openshift-merge-robot @mandre