Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1896329: Drop kubelet logging back down to level 3 #2244

Merged
merged 1 commit into from Nov 19, 2020
Merged

[release-4.6] Bug 1896329: Drop kubelet logging back down to level 3 #2244

merged 1 commit into from Nov 19, 2020

Conversation

rphillips
Copy link
Contributor

Rebased with the e2e fix #2239

Cherry pick of #2211

@kikisdeliveryservice @rphillips
Drop kubelet logging back down to level 3
1ec49e0 
KUBELET_LOG_LEVEL was bumped to level 4 to aid in
debugging some issue by node team (see openshift#1672).
However customers upgrading to 4.5 in prod, are seeing this bump
causing extra GBs of data to be saved.

Closes: BZ 1895385
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

@rphillips: This pull request references Bugzilla bug 1896329, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1895385 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1895385 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

[release-4.6] Bug 1896329: Drop kubelet logging back down to level 3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@rphillips rphillips mentioned this pull request Nov 19, 2020
Closed
@rphillips
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@rphillips: This pull request references Bugzilla bug 1896329, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1895385 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1895385 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 19, 2020
@kikisdeliveryservice kikisdeliveryservice added 4.6 Work targeted for 4.6 and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Nov 19, 2020
@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 19, 2020
@openshift-merge-robot
Copy link
Contributor

@rphillips: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-gcp-op 1ec49e0 link /test okd-e2e-gcp-op
ci/prow/okd-e2e-upgrade 1ec49e0 link /test okd-e2e-upgrade
ci/prow/okd-e2e-aws 1ec49e0 link /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7 1ec49e0 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1f2ecb8 into openshift:release-4.6 Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

@rphillips: All pull requests linked via external trackers have merged:

Bugzilla bug 1896329 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1896329: Drop kubelet logging back down to level 3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor Author

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link

@rphillips: #2244 failed to apply on top of branch "release-4.5":

Applying: Drop kubelet logging back down to level 3
Using index info to reconstruct a base tree...
A	templates/master/01-master-kubelet/_base/units/kubelet.service.yaml
A	templates/worker/01-worker-kubelet/_base/units/kubelet.service.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/worker/01-worker-kubelet/_base/units/kubelet.yaml
CONFLICT (content): Merge conflict in templates/worker/01-worker-kubelet/_base/units/kubelet.yaml
Auto-merging templates/master/01-master-kubelet/baremetal/units/kubelet.yaml
CONFLICT (content): Merge conflict in templates/master/01-master-kubelet/baremetal/units/kubelet.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Drop kubelet logging back down to level 3
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels
4.6 Work targeted for 4.6 approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rphillips @openshift-ci-robot @kikisdeliveryservice @openshift-merge-robot @openshift-cherrypick-robot @ecordell