Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openshift/api and openshift/client-go #2253

Merged
merged 1 commit into from Nov 24, 2020

Conversation

umohnani8
Copy link
Contributor

Signed-off-by: Urvashi Mohnani umohnani@redhat.com

- What I did
Pull in api updates to the Image CR that has the new
containerRuntimeSearchRegistries option.

- How to verify it

- Description for the changelog
Bump openshift/api and openshift/client-go deps

Pull in api updates to the Image CR that has the new
containerRuntimeSearchRegistries option.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@umohnani8
Copy link
Contributor Author

@yuqi-zhang @kikisdeliveryservice PTAL

@kikisdeliveryservice
Copy link
Contributor

/test e2e-aws-serial

@kikisdeliveryservice
Copy link
Contributor

@umohnani8 this is just a vendor bump but nothing else that i see, right?

@umohnani8
Copy link
Contributor Author

@kikisdeliveryservice yup, just a vendor bump. I will have a follow up PR implementing the new option, but need this in so that the manifest gets the new option.

@umohnani8
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

@umohnani8: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-step-registry 71fcf50 link /test e2e-ovn-step-registry
ci/prow/okd-e2e-aws 71fcf50 link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

/skip

Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @runcom give the final lgtm

/assign @runcom

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@runcom
Copy link
Member

runcom commented Nov 24, 2020

I'll let @runcom give the final lgtm

thanks @kikisdeliveryservice

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 294b9ff into openshift:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants