Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1899350: Include dhcp client-id and bond options during ovs-configuration #2264

Merged
merged 3 commits into from Dec 5, 2020
Merged

Bug 1899350: Include dhcp client-id and bond options during ovs-configuration #2264

merged 3 commits into from Dec 5, 2020

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Nov 30, 2020

Adds copying over the dhcp client-id as well as bond options from the interface being migrated over to OVS.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Bugzilla bug 1899350, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1899350: Include dhcp client-id and bond options during ovs-configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 30, 2020
@trozet
Copy link
Contributor Author

trozet commented Nov 30, 2020

@danwinship @dcbw

@cgwalters
Copy link
Member

I think it'd be pretty easy BTW to:

  • Move this logic into a container in the SDN
  • Change the MCO templates to pull down and execute that container via podman before starting kubelet, much like we do with machine-config-daemon-firstboot.service

@danwinship
Copy link
Contributor

(Filed a jira card about moving the logic out of MCO: https://issues.redhat.com/browse/SDN-1374)

@trozet
Add support for dhcp client ID with ovs-config
da45999 
For IPv4 the existing connection may be configured with a specific DHCP
client ID to use. We should use that for br-ex as well.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@trozet
Include bond options for ovs-configuration
2c39f3f 
If we detect the interface type is bond then we should check to see if
any bond options exist and configure those on the new connection.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@trozet
ovs-config: Fix connection parsing for iface
a22352a 
The current regex may accidentally match substrings of the desired
interface and return the wrong connection. This changes the regex to
ensure exact match.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@trozet
Copy link
Contributor Author

trozet commented Dec 3, 2020

/retest

@celebdor
Copy link
Contributor

celebdor commented Dec 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@trozet
Copy link
Contributor Author

trozet commented Dec 3, 2020

/retest

@kikisdeliveryservice
Copy link
Contributor

is this ovn test supposed to pass @trozet

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2020
kikisdeliveryservice
kikisdeliveryservice approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, tim if you don't need that test to pass remove the hold

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, kikisdeliveryservice, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@trozet
Copy link
Contributor Author

trozet commented Dec 4, 2020

the test got far enough that it made it past what this patch invokes, so the failure isn't due to this

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

/skip

@celebdor
Copy link
Contributor

celebdor commented Dec 4, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 5, 2020 •
edited

@trozet: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws a22352a link /test okd-e2e-aws
ci/prow/e2e-ovn-step-registry a22352a link /test e2e-ovn-step-registry
ci/prow/e2e-aws-workers-rhel7 a22352a link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 50e3415 into openshift:master Dec 5, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 1899350 has been moved to the MODIFIED state.

In response to this:

Bug 1899350: Include dhcp client-id and bond options during ovs-configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship requested changes

@celebdor celebdor celebdor left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@celebdor celebdor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@trozet @openshift-ci-robot @cgwalters @danwinship @celebdor @kikisdeliveryservice @openshift-bot @openshift-merge-robot