New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQ: Document /run/machine-config-daemon-force #2265
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry one more thing. To be more specific, you can only use this to "skip validation". The MCD itself cannot revert anything, it can only overwrite when an update is triggered. So this would only really work if you're seeing:
unexpected on-disk state validating against rendered-xxx
and in the node annotations, the
currentConfig
!=desiredConfig
then this would cause the validation to get passed, and the new config would get applied without asking questions, most likely overwriting the old file.
If there was no update and you want to revert the changes you did manually, doing a forcefile would cause nothing to happen. You would instead have to go manually edit the desiredConfig, again something we don't want people to do without knowing the correct background.
I'm hesitant to add this to the openshift docs for the reason that the hard part is determining the state you're in and what you can do to fix it. Force doesn't really fix anything and could make the cluster worse, since the fundamental cause of the drift might be something else. (we've had problems of community operators overwriting crio conf, for example)
Maybe similarly, we should instead just say "the MCO can't reprovision nodes today. If you are seeing a validation error and just want to force an update to a new render config, do this".?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree about jerry's point adding this to openshift docs and the potential compounding danger of suggesting this without enough nuance.