Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate manifests for single-node-developer cluster profile #2268

Merged

Conversation

guillaumerose
Copy link
Contributor

This implements phase 1 of openshift/enhancements#482

@cfergeau
Copy link

cfergeau commented Dec 2, 2020

/retest

1 similar comment
@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guillaumerose, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@openshift-merge-robot
Copy link
Contributor

@guillaumerose: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 42b6304 link /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7 42b6304 link /test e2e-aws-workers-rhel7
ci/prow/e2e-ovn-step-registry 42b6304 link /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Member

This is going to conflict with #2221 but I guess whoever merges second will just win the conflict resolution game 😉 Well to be fair to him since it was first I added lgtm.

I thought CodeReady wasn't using the MCO because it wasn't doing in-place updates? In light of openshift/enhancements#504 though perhaps that is changing?

@kikisdeliveryservice
Copy link
Contributor

This was discussed in the team meeting and @runcom and @crawford are both aware said that we can merge this for 4.7 for CRC.

@runcom
Copy link
Member

runcom commented Dec 3, 2020

/approve
/lgtm

@kikisdeliveryservice kikisdeliveryservice added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@kikisdeliveryservice
Copy link
Contributor

ugh labelling isn't getting picked up... reported in 4-dev =(

@kikisdeliveryservice
Copy link
Contributor

/skip

@openshift-merge-robot openshift-merge-robot merged commit 5aa4656 into openshift:master Dec 3, 2020
@guillaumerose
Copy link
Contributor Author

@cgwalters It runs once when we bootstrap the cluster and then we disable it. But the long term goal is to keep it activated (and handle reboot, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants