New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate manifests for single-node-developer cluster profile #2268
Annotate manifests for single-node-developer cluster profile #2268
Conversation
This implements phase 1 of openshift/enhancements#482
/retest |
1 similar comment
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guillaumerose, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@guillaumerose: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is going to conflict with #2221 but I guess whoever merges second will just win the conflict resolution game 😉 Well to be fair to him since it was first I added lgtm. I thought CodeReady wasn't using the MCO because it wasn't doing in-place updates? In light of openshift/enhancements#504 though perhaps that is changing? |
/approve |
ugh labelling isn't getting picked up... reported in 4-dev =( |
/skip |
@cgwalters It runs once when we bootstrap the cluster and then we disable it. But the long term goal is to keep it activated (and handle reboot, etc.). |
This implements phase 1 of openshift/enhancements#482