New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix broken ostree url #2270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
/lgtm
This is a doc update PR, test shouldn't be effected by it. |
Can you squash: #2269 into this commit as requested since it's all just docs changes? If you have any other changes please add them to this pr. Thanks! /hold |
/skip |
/override ci/prow/e2e-aws-serial |
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-aws-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
leaving this open for a bit in case there are other docs changes to be added /skip |
Also whenever you're done can you squash all of the typo commits into 1 (no rush)? Thank you! |
Thanks for the hold. I've just finished reading all the documentation. |
@mrVectorz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The ostree link is now broken as the site moved Fix typos and some EN syntax
/skip |
thanks for all of the updates @mrVectorz ! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, mrVectorz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-aws-serial |
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-aws-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The ostree link is now broken as the site moved
https://ostree.readthedocs.io now redirects to https://ostreedev.github.io/ and the rest of the path changed, so we end up with a 404.