Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken ostree url #2270

Merged
merged 1 commit into from Dec 1, 2020

Conversation

mrVectorz
Copy link
Contributor

The ostree link is now broken as the site moved
https://ostree.readthedocs.io now redirects to https://ostreedev.github.io/ and the rest of the path changed, so we end up with a 404.

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2020
@sinnykumari
Copy link
Contributor

This is a doc update PR, test shouldn't be effected by it.
/skip

@kikisdeliveryservice
Copy link
Contributor

Can you squash: #2269 into this commit as requested since it's all just docs changes? If you have any other changes please add them to this pr.

Thanks!

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 1, 2020
@kikisdeliveryservice
Copy link
Contributor

/skip

@kikisdeliveryservice
Copy link
Contributor

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-agnostic-upgrade

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

leaving this open for a bit in case there are other docs changes to be added

/skip

@kikisdeliveryservice kikisdeliveryservice changed the title Fix broken ostree url docs: Fix broken ostree url Dec 1, 2020
@kikisdeliveryservice
Copy link
Contributor

Also whenever you're done can you squash all of the typo commits into 1 (no rush)? Thank you!

@mrVectorz
Copy link
Contributor Author

Thanks for the hold. I've just finished reading all the documentation.
I did leave some English syntax issues that don't impact meaning at all to avoid spamming too many commits.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 1, 2020

@mrVectorz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 303873a1458f0b201a3dcef22db1548e0afb81f7 link /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7 303873a1458f0b201a3dcef22db1548e0afb81f7 link /test e2e-aws-workers-rhel7
ci/prow/e2e-ovn-step-registry 303873a1458f0b201a3dcef22db1548e0afb81f7 link /test e2e-ovn-step-registry
ci/prow/e2e-metal-ipi 1ba301546d1229bdf0349477eea50d044d0f12f1 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The ostree link is now broken as the site moved
Fix typos and some EN syntax
@kikisdeliveryservice
Copy link
Contributor

/skip

@kikisdeliveryservice
Copy link
Contributor

thanks for all of the updates @mrVectorz !

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice, mrVectorz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice
Copy link
Contributor

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-agnostic-upgrade

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1d4e8d0 into openshift:master Dec 1, 2020
@mrVectorz mrVectorz deleted the patch-2 branch December 1, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants