Revert "Bug 1888565: daemon: Explicitly start rpm-ostreed"

[YuviGold]

Reverts #2291

assisted-installer is running MCD inside custom podman container as once from[1].
Reverting this PR until better consider once from usage.

/cc @cgwalters

[1] https://github.com/openshift/assisted-installer/blob/e3c999d9f16f8c8e9fa6d4105591da33ad84fc62/src/installer/installer.go#L218-L224

[openshift-ci-robot]

@YuviGold: This pull request references Bugzilla bug 1888565, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Revert "Bug 1888565: daemon: Explicitly start rpm-ostreed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sinnykumari]

I haven't tried myself once-from usecase. My understanding was that m-c-d onceFrom is mainly there to run partial functionality of MCO on non-coreOS system like RHEL.
To help understand can you please tell what exact failure you are seeing caused by #2291?

[YuviGold]

I haven't tried myself once-from usecase. My understanding was that m-c-d onceFrom is mainly there to run partial functionality of MCO on non-coreOS system like RHEL.
To help understand can you please tell what exact failure you are seeing caused by #2291?

Failed to initialize single run daemon: failed to start rpm-ostreed: error running systemctl start rpm-ostreed: Failed to connect to bus: No data available

/bugzilla refresh

[openshift-ci-robot]

@YuviGold: This pull request references Bugzilla bug 1888565, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

I haven't tried myself once-from usecase. My understanding was that m-c-d onceFrom is mainly there to run partial functionality of MCO on non-coreOS system like RHEL.
To help understand can you please tell what exact failure you are seeing caused by #2291?

Failed to initialize single run daemon: failed to start rpm-ostreed: error running systemctl start rpm-ostreed: Failed to connect to bus: No data available

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yevgeny-shnaidman]

I haven't tried myself once-from usecase. My understanding was that m-c-d onceFrom is mainly there to run partial functionality of MCO on non-coreOS system like RHEL.
To help understand can you please tell what exact failure you are seeing caused by #2291?

Since in our case the bootstrap node is booted up using RHCOS LiveCD and we fetch the bootstrap.ign file afterwards, we use mco with once-from flag to parse the bootstrap.ign and install bootstrap.ign, and then run bootkube.sh code

[YuviGold]

/retest
/bugzilla refresh

[openshift-ci-robot]

@YuviGold: This pull request references Bugzilla bug 1888565, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/retest
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

Yeah I asked them to revert this; we really need a CI context on here that tests once-from.
/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, YuviGold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[cgwalters]

Here's a PR to add another optional test context to this repo: openshift/release#14300
Sinny do you want to lgtm?

[openshift-merge-robot]

@YuviGold: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	2ffb442	link	/test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@YuviGold: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2291
• openshift/machine-config-operator#2296

Bugzilla bug 1888565 has been moved to the MODIFIED state.

In response to this:

Revert "Bug 1888565: daemon: Explicitly start rpm-ostreed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.