Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1899622: backport bond options fixes #2298

Merged
merged 3 commits into from Dec 22, 2020
Merged

[release-4.6] Bug 1899622: backport bond options fixes #2298

merged 3 commits into from Dec 22, 2020

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Dec 14, 2020

Includes fixes for bond options, dhcp client id, and iface parsing.

@trozet
Add support for dhcp client ID with ovs-config
1cf3475 
For IPv4 the existing connection may be configured with a specific DHCP
client ID to use. We should use that for br-ex as well.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit da45999)
@trozet
Include bond options for ovs-configuration
abe5a41 
If we detect the interface type is bond then we should check to see if
any bond options exist and configure those on the new connection.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit 2c39f3f)
@trozet
ovs-config: Fix connection parsing for iface
5e994b2 
The current regex may accidentally match substrings of the desired
interface and return the wrong connection. This changes the regex to
ensure exact match.

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit a22352a)
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Bugzilla bug 1899622, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1899350 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1899350 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

Bug 1899622: backport bond options fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 14, 2020
@trozet
Copy link
Contributor Author

trozet commented Dec 14, 2020

@danwinship @celebdor

@danwinship
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@kikisdeliveryservice kikisdeliveryservice added the 4.6 Work targeted for 4.6 label Dec 17, 2020
@kikisdeliveryservice kikisdeliveryservice changed the title Bug 1899622: backport bond options fixes [release-4.6] Bug 1899622: backport bond options fixes Dec 17, 2020
@openshift-merge-robot
Copy link
Contributor

@trozet: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 5e994b2 link /test okd-e2e-aws
ci/prow/okd-e2e-gcp-op 5e994b2 link /test okd-e2e-gcp-op
ci/prow/okd-e2e-upgrade 5e994b2 link /test okd-e2e-upgrade
ci/prow/e2e-agnostic-upgrade 5e994b2 link /test e2e-agnostic-upgrade
ci/prow/e2e-aws-workers-rhel7 5e994b2 link /test e2e-aws-workers-rhel7
ci/prow/e2e-ovn-step-registry 5e994b2 link /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@trozet
Copy link
Contributor Author

trozet commented Dec 18, 2020

/assign @kikisdeliveryservice

@markmc
Copy link

markmc commented Dec 21, 2020

(patch manager) looks like a fix for an issue that is affecting some real-world users

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 21, 2020
@markmc
Copy link

markmc commented Dec 22, 2020

@trozet @danwinship still needs approved label

@trozet
Copy link
Contributor Author

trozet commented Dec 22, 2020

/assign @runcom

@trozet
Copy link
Contributor Author

trozet commented Dec 22, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, trozet, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit eab9c35 into openshift:release-4.6 Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 1899622 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1899622: backport bond options fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2020

@trozet: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-gcp-op 5e994b2 link /test okd-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

Assignees

@danwinship danwinship

@runcom runcom

@kikisdeliveryservice kikisdeliveryservice

Labels
4.6 Work targeted for 4.6 approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@trozet @openshift-ci-robot @danwinship @openshift-merge-robot @markmc @openshift-bot @yuqi-zhang @runcom @kikisdeliveryservice