Bug 1901376: Fix upgrade issue with DNS controllerconfig field #2306
Conversation
The initial implementation of this had incorrect logic for handling merges of configs. Because DNS is a new field, the existing one will always be nil on upgrade. We need to remove the nil check for the existing object so that it can be populated with the new object.
openshift-ci-robot
added
the
bugzilla/severity-high
|
@cybertron: This pull request references Bugzilla bug 1901376, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
There was a problem hiding this comment.
Worked with @cybertron on this fix. As Baremetal didn't have an upgrade job it wasn't caught the first time.
This is correct now.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/skip |
|
/test e2e-aws-serial |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@cybertron: All pull requests linked via external trackers have merged: Bugzilla bug 1901376 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The initial implementation of this had incorrect logic for handling
merges of configs. Because DNS is a new field, the existing one will
always be nil on upgrade. We need to remove the nil check for the
existing object so that it can be populated with the new object.