Bug 1910165: [baremetal] Correctly handle multiple ipv6 addresses on interface #2312
Conversation
Generally speaking there should only be one address configured per interface. However, in some ipv6 environments a node may get an address from both DHCP and SLAAC. In this case, we need to make sure that the ipv6 DHCP to static dispatcher script can handle the inputs it gets. Previously, the lease time check would get back a single string with multiple values. This caused the if to always fail, which meant we would do static configuration even if the DHCP lease was not infinite. This change further filters the lease time query to ensure it only returns the value for the specific DHCP address in question. It also improves the address assignment logic to ensure that we get the correct address no matter how many are present on the interface.
cybertron
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@cybertron: This pull request references Bugzilla bug 1910165, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @celebdor |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, cybertron, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws |
|
@cybertron: All pull requests linked via external trackers have merged: Bugzilla bug 1910165 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Generally speaking there should only be one address configured per
interface. However, in some ipv6 environments a node may get an
address from both DHCP and SLAAC. In this case, we need to make sure
that the ipv6 DHCP to static dispatcher script can handle the inputs
it gets.
Previously, the lease time check would get back a single string
with multiple values. This caused the if to always fail, which
meant we would do static configuration even if the DHCP lease was
not infinite.
This change further filters the lease time query to ensure it only
returns the value for the specific DHCP address in question. It also
improves the address assignment logic to ensure that we get the
correct address no matter how many are present on the interface.
- What I did
- How to verify it
- Description for the changelog