Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1882140: KubeletConfig: Add the description to kubelet config CRD #2320

Merged
merged 1 commit into from Jan 8, 2021

Conversation

harche
Copy link
Contributor

@harche harche commented Jan 6, 2021

Signed-off-by: Harshal Patil harpatil@redhat.com

- What I did
Added a description to the kubelet configuration CRD

- How to verify it
oc explain KubeletConfig.spec.kubeletConfig --recursive=true should show following DESCRIPTION field instead of an empty entry.

DESCRIPTION:
     The fields of the kubelet configuration are defined in kubernetes upstream.
     Please refer to the types defined in the version/commit used by OpenShift
     of the upstream kubernetes.

- Description for the changelog
Added the description to kubelet config CRD

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@harche: This pull request references Bugzilla bug 1882140, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1882140: KubeletConfig: Add the description to kubelet config CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 6, 2021
@harche
Copy link
Contributor Author

harche commented Jan 6, 2021

/test e2e-metal-ipi

@harche
Copy link
Contributor Author

harche commented Jan 6, 2021

/cc @rphillips

@harche
Copy link
Contributor Author

harche commented Jan 6, 2021

/test e2e-ovn-step-registry

@harche
Copy link
Contributor Author

harche commented Jan 6, 2021

/test okd-e2e-aws

@harche
Copy link
Contributor Author

harche commented Jan 6, 2021

/test e2e-ovn-step-registry

@kikisdeliveryservice
Copy link
Contributor

/assign @rphillips

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, kikisdeliveryservice, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5f4b62e into openshift:master Jan 8, 2021
@openshift-ci-robot
Copy link
Contributor

@harche: All pull requests linked via external trackers have merged:

Bugzilla bug 1882140 has been moved to the MODIFIED state.

In response to this:

Bug 1882140: KubeletConfig: Add the description to kubelet config CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants