Bug 1911632: daemon/update: fix regression in realtime upgrades #2329
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@darkmuggle: This pull request references Bugzilla bug 1911632, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
Calling this WIP while I test. |
|
Sigh, this regression occurred due to adb9e70#diff-349c0748c3f52201852d3027c29daf618b45300b949482728df6666a3f9ba245R963 . I blame copy paste |
During the extension refactor [1], the upgrade logic that installed the realtime kernel RPM's was lost. 'rpm-ostree' does not have the ability to do non-local replacements of installed overrides (the packages are shipped as a bona-fida repo). The cleanest method for handling the upgrade is to remove the override and the install the new ones; this avoids having to calculate the rpm dependencies. [1] openshift@adb9e70#diff-349c0748c3f52201852d3027c29daf618b45300b949482728df6666a3f9ba245R963
darkmuggle
force-pushed
the
pr/fix-upgrades
branch
from
b885c80
to
8405d53
Compare
|
@darkmuggle: This pull request references Bugzilla bug 1911632, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkmuggle, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@darkmuggle: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@darkmuggle: All pull requests linked via external trackers have merged: Bugzilla bug 1911632 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
During the extension refactor [1], the upgrade logic that installed the
realtime kernel RPM's was lost. 'rpm-ostree' does not have the ability
to do non-local replacements of installed overrides (the packages are
shipped as a bona-fida repo). The cleanest method for handling the
upgrade is to remove the override and the install the new ones; this
avoids having to calculate the rpm dependencies.