New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.6] Bug 1914892: update.go: only set BFQ scheduler for masters #2330
[release-4.6] Bug 1914892: update.go: only set BFQ scheduler for masters #2330
Conversation
In openshift#2243 we made it so that we switch to BFQ during updates, but unintentially made it also apply to workers. This does not work on RHEL7 since it breaks on both trying to set the scheduler as well as finding the root device. Change the behaviour back to master only, which also implies that only CoreOS variants will do this. Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
@openshift-cherrypick-robot: Bugzilla bug 1913154 has been cloned as Bugzilla bug 1914892. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1914892, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this on 4.6.6->4.6.10 osimage update, and the rhel node was able to upgrade (getting past this error)
If someone can verify the 4.7 BZ I think this can be merged
Thanks Jerry for testing! |
/bugzilla refresh |
@sinnykumari: This pull request references Bugzilla bug 1914892, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/skip |
backport needed asap /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The MCO team has identified this as urgent. RHEL 7 worker nodes will fail to upgrade and there are no known workarounds. |
/bugzilla refresh |
@kikisdeliveryservice: This pull request references Bugzilla bug 1914892, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1914892, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Retesting 4.7 fix before merging this ^^^ |
Waiting for parent bug to be |
QE is actively looking at the 4.7 BZ to verify. |
/bugzilla refresh |
@ashcrow: This pull request references Bugzilla bug 1914892, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1914892 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2325
/assign sinnykumari