Bug 1918471: fix custom featuregates and add a unit test

[rphillips]

- What I did
Fixed applying Custom FeatureGate to the MCO. Prior to this fix 'CustomNoUpgrade' featuregates would not be injected into ignition correctly. This fix adds a unit test as well.

apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  name: cluster
spec:
  featureSet: "CustomNoUpgrade"
  customNoUpgrade:
    enabled:
      - GracefulNodeShutdown
      - APIPriorityAndFairness
      - RotateKubeletServerCertificate
      - SupportPodPidsLimit
      - NodeDisruptionExclusion
      - ServiceNodeExclusion
      - SCTPSupport
    disabled:
      - LegacyNodeRoleBehavior
      - RemoveSelfLink

- How to verify it
Edit the cluster featuregate and paste in this spec. Also rely on the added unit test.

- Description for the changelog

[openshift-ci-robot]

@rphillips: This pull request references Bugzilla bug 1918471, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1918471: fix custom featuregates and add a unit test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

/bugzilla refresh

[openshift-ci-robot]

@rphillips: This pull request references Bugzilla bug 1918471, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

/bugzilla refresh

[openshift-ci-robot]

@rphillips: This pull request references Bugzilla bug 1918471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[haircommander]

one nit, non blocking
/approve

[QiWang19]

lgtm

[mrunalp]

/approve

[kikisdeliveryservice]

approve but also agree on the const suggestion from @haircommander

[rphillips]

@haircommander updated to fix your nit. Thanks!

[sinnykumari]

/retest

[haircommander]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kikisdeliveryservice, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[umohnani8]

LGTM

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@rphillips: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2352

Bugzilla bug 1918471 has been moved to the MODIFIED state.

In response to this:

Bug 1918471: fix custom featuregates and add a unit test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.