[release-4.5] Bug 1880333: bump k8s.io/client-go to 0.18.6

[kikisdeliveryservice]

• bump k8s.io/client-go to 0.18.16 to pick up fix along with other k8s.io components
• bump kubernets to v1.18.6 to keep version parity.

[openshift-ci-robot]

@kikisdeliveryservice: This pull request references Bugzilla bug 1880333, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.z) matches configured target release for branch (4.5.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1880369 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1880369 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

In response to this:

Bug 1880333: bump client go to 0.18.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

I think I finally got this...

@p0lyn0mial PTAL

[p0lyn0mial]

@kikisdeliveryservice I don't see any files in the vendor directory. Only changes to the go.mod file. Have you forgotten to push some files :)?

[sinnykumari]

It needs updating client-go version to v0.18.6 in replace section as well https://github.com/openshift/machine-config-operator/blob/release-4.5/go.mod#L96 . go.mod replace section allows user to pin a dependency to version projects want to stick over.

[sinnykumari]

LGTM
/approve

@p0lyn0mial Feel free to lgtm

[openshift-ci-robot]

@kikisdeliveryservice: This pull request references Bugzilla bug 1880333, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.z) matches configured target release for branch (4.5.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1880369 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1880369 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

In response to this:

[release-4.5] Bug 1880333: bump k8s.io/client-go to 0.18.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[p0lyn0mial]

/lgtm

many thanks for the pr.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, p0lyn0mial, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@kikisdeliveryservice: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2354

Bugzilla bug 1880333 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1880333: bump k8s.io/client-go to 0.18.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.