Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1919272: [release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved #2356

Merged
merged 1 commit into from Feb 11, 2021
Merged

Bug 1919272: [release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved #2356

merged 1 commit into from Feb 11, 2021

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jan 21, 2021 •
edited

FCOS 33 doesn't use NM to manage resolv.conf. Instead it uses systemd-resolved.
The script should not replace /etc/resolv.conf in this case, but instead create a dropin for systemd-resolved.

Cherry-pick of #2359 on release-4.6

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member Author

/hold

Testing it now

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2021
@vrutkovs vrutkovs force-pushed the 4.6-kni-sed-inplace branch 2 times, most recently from 033e1f2 to 5565d66 Compare January 21, 2021 18:54
@vrutkovs
Copy link
Member Author

/test e2e-vsphere

@vrutkovs vrutkovs force-pushed the 4.6-kni-sed-inplace branch 3 times, most recently from 659b3fc to f498b83 Compare January 21, 2021 19:46
@vrutkovs
Copy link
Member Author

/retest

1 similar comment
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs vrutkovs mentioned this pull request Jan 22, 2021
Merged
@sinnykumari
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2021
@sinnykumari
Copy link
Contributor

lol, gave lgtm on wrong PR. It was intended for openshift/release#15145
/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2021
@vrutkovs
Copy link
Member Author

/test okd-e2e-vsphere

@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

OKD vSphere setup reaches test phase, fails on unit tests

@vrutkovs vrutkovs changed the title [release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved Bug 1919272: [release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved Jan 22, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Bugzilla bug 1919272, which is invalid:

  • expected dependent Bugzilla bug 1919271 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1919272: [release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 22, 2021
@vrutkovs
Copy link
Member Author

/hold cancel

Seems to work on CI

@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Fedosin
Fedosin approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, Fedosin, iamemilio, jcpowermac, kikisdeliveryservice, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Gal-Zaidman
Copy link
Contributor

/test e2e-ovirt

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Gal-Zaidman
Copy link
Contributor

/test e2e-ovirt

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 9, 2021

/test e2e-ovirt
/skip

Skipping OKD tests - these fail on known flakes

@vrutkovs vrutkovs mentioned this pull request Feb 10, 2021
Closed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2021 •
edited

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-gcp-op 951f1a9 link /test okd-e2e-gcp-op
ci/prow/okd-e2e-vsphere 951f1a9 link /test okd-e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 54a74ce into openshift:release-4.6 Feb 11, 2021
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: All pull requests linked via external trackers have merged:

Bugzilla bug 1919272 has been moved to the MODIFIED state.

In response to this:

Bug 1919272: [release-4.6] NM resolve prepender: support appending a nameserver for systemd-resolved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs mentioned this pull request Feb 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@Fedosin Fedosin Fedosin approved these changes

@runcom runcom Awaiting requested review from runcom

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@celebdor celebdor

@sinnykumari sinnykumari

@jcpowermac jcpowermac

@iamemilio iamemilio

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet