Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1904133: kubeletcfg: fix repeated status error msg #2369

Merged
merged 1 commit into from Jan 30, 2021
Merged

Bug 1904133: kubeletcfg: fix repeated status error msg #2369

merged 1 commit into from Jan 30, 2021

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jan 27, 2021 •
edited

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1904133

Signed-off-by: Qi Wang qiwan@redhat.com

- What I did
For kubeletconfig, do not append new status conditions if the error message stays the same
to avoid the repeated same conditions
This patch mirrors the handlerErr of the container runtime config controller.
- How to verify it

Verify this by applying the problematic YAML and waiting for several minutes to check the status

Status:
  Conditions:
    Last Transition Time:  2021-01-27T21:19:29Z
    Message:               Error: could not find any MachineConfigPool set for KubeletConfig
    Status:                False
    Type:                  Failure
Events:                    <none>

// wait several minutes
Status:
  Conditions:
    Last Transition Time:  2021-01-27T21:26:16Z
    Message:               Error: could not find any MachineConfigPool set for KubeletConfig
    Status:                False
    Type:                  Failure
Events:                    <none>

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 27, 2021
@openshift-ci-robot
Copy link
Contributor

@QiWang19: This pull request references Bugzilla bug 1904133, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1904133: fix repeated status error msg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 27, 2021
@openshift-ci-robot
Copy link
Contributor

@QiWang19: This pull request references Bugzilla bug 1904133, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

/assign @cgwalters

kikisdeliveryservice
kikisdeliveryservice suggested changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reading this you'll end up with the same err msg with updated timestamp so itll just stay 1 message? Makes sense

But can you update your commit message to indicate this is a kubelet config change?

@kikisdeliveryservice kikisdeliveryservice changed the title Bug 1904133: fix repeated status error msg Bug 1904133: kubeletcfg: fix repeated status error msg Jan 27, 2021
@cynepco3hahue cynepco3hahue mentioned this pull request Jan 28, 2021
Merged
@QiWang19
Bug 1904133: fix kubeletconfig repeated status error msg
d9a32f8 
kubelet config does not append new status conditions if error message stays the same
 to avoid the repeated same conditions
This patch mirrors the handlerErr of the container runtime config controller.

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@QiWang19: This pull request references Bugzilla bug 1904133, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1904133: kubeletcfg: fix repeated status error msg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@QiWang19
Copy link
Member Author

@kikisdeliveryservice PTAL. I changed the commit message to note it's a kubelet config change.

@QiWang19
Copy link
Member Author

/retest

1 similar comment
@QiWang19
Copy link
Member Author

/retest

@QiWang19
Copy link
Member Author

/test e2e-agnostic-upgrade

@QiWang19
Copy link
Member Author

/test e2e-aws-workers-rhel7
/test e2e-agnostic-upgrade

@QiWang19
Copy link
Member Author

/test e2e-aws-workers-rhel7

@kikisdeliveryservice
Copy link
Contributor

the rhel7 job is red no worries on retesting.

/skip

kikisdeliveryservice
kikisdeliveryservice approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @QiWang19
for final approval:

/assign @rphillips

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@kikisdeliveryservice
Copy link
Contributor

/skip

@QiWang19
Copy link
Member Author

/assign @rphillips

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, QiWang19, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2021 •
edited

@QiWang19: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 d9a32f8 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a060922 into openshift:master Jan 30, 2021
@openshift-ci-robot
Copy link
Contributor

@QiWang19: All pull requests linked via external trackers have merged:

Bugzilla bug 1904133 has been moved to the MODIFIED state.

In response to this:

Bug 1904133: kubeletcfg: fix repeated status error msg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@runcom runcom Awaiting requested review from runcom

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@rphillips rphillips

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@QiWang19 @openshift-ci-robot @kikisdeliveryservice @rphillips @openshift-bot @cgwalters @openshift-merge-robot