Bug 1923874: KubeletConfig: Drop validation for kubeletconfig

[harche]

Signed-off-by: Harshal Patil harpatil@redhat.com

Fixes: #2357

- What I did
Drop all the validation for KubeletConfig

- How to verify it

apiVersion: machineconfiguration.openshift.io/v1
kind: KubeletConfig
metadata:
  name: set-max-pods
spec:
  logLevel: 5
  machineConfigPoolSelector:
    matchLabels:
      pools.operator.machineconfiguration.openshift.io/worker: ""
  kubeletConfig:
      evictionHard:
        imagefs.available: 10%
        imagefs.inodesFree: 5%
        memory.available: 200Mi
        nodefs.available: 5%
        nodefs.inodesFree: 4%
      evictionPressureTransitionPeriod: 0s
      evictionSoft:
        imagefs.available: 15%
        imagefs.inodesFree: 10%
        memory.available: 500Mi
        nodefs.available: 10%
        nodefs.inodesFree: 5%
      evictionSoftGracePeriod:
        imagefs.available: 1m30s
        imagefs.inodesFree: 1m30s
        memory.available: 1m30s
        nodefs.available: 1m30s
        nodefs.inodesFree: 1m30s
      imageGCHighThresholdPercent: 80
      imageGCLowThresholdPercent: 75
      imageMinimumGCAge: 5m
      maxPods: 240
      podsPerCore: 80

Try to apply above kubeletconfig and the validation should pass fine like this,

Name:         set-max-pods
Namespace:    
Labels:       <none>
Annotations:  API Version:  machineconfiguration.openshift.io/v1
Kind:         KubeletConfig
Metadata:
  Creation Timestamp:  2021-02-04T06:34:03Z
  Finalizers:
    99-worker-generated-kubelet
  Generation:  1
  Managed Fields:
    API Version:  machineconfiguration.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:finalizers:
          .:
          v:"99-worker-generated-kubelet":
      f:status:
        .:
        f:conditions:
    Manager:      machine-config-controller
    Operation:    Update
    Time:         2021-02-04T06:34:03Z
    API Version:  machineconfiguration.openshift.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:kubeletConfig:
          .:
          f:evictionHard:
          f:evictionPressureTransitionPeriod:
          f:evictionSoft:
          f:evictionSoftGracePeriod:
          f:imageGCHighThresholdPercent:
          f:imageGCLowThresholdPercent:
          f:imageMinimumGCAge:
          f:maxPods:
          f:podsPerCore:
        f:logLevel:
        f:machineConfigPoolSelector:
          .:
          f:matchLabels:
            .:
            f:pools.operator.machineconfiguration.openshift.io/worker:
    Manager:         oc
    Operation:       Update
    Time:            2021-02-04T06:34:03Z
  Resource Version:  404911
  Self Link:         /apis/machineconfiguration.openshift.io/v1/kubeletconfigs/set-max-pods
  UID:               b07988d1-01c7-44de-b70e-3ca9911aaf52
Spec:
  Kubelet Config:
    Eviction Hard:
      imagefs.available:                  10%
      imagefs.inodesFree:                 5%
      memory.available:                   200Mi
      nodefs.available:                   5%
      nodefs.inodesFree:                  4%
    Eviction Pressure Transition Period:  0s
    Eviction Soft:
      imagefs.available:   15%
      imagefs.inodesFree:  10%
      memory.available:    500Mi
      nodefs.available:    10%
      nodefs.inodesFree:   5%
    Eviction Soft Grace Period:
      imagefs.available:              1m30s
      imagefs.inodesFree:             1m30s
      memory.available:               1m30s
      nodefs.available:               1m30s
      nodefs.inodesFree:              1m30s
    Image GC High Threshold Percent:  80
    Image GC Low Threshold Percent:   75
    Image Minimum GC Age:             5m
    Max Pods:                         240
    Pods Per Core:                    80
  Log Level:                          5
  Machine Config Pool Selector:
    Match Labels:
      pools.operator.machineconfiguration.openshift.io/worker:  
Status:
  Conditions:
    Last Transition Time:  2021-02-04T06:34:03Z
    Message:               Success
    Status:                True
    Type:                  Success
Events:                    <none>

- Description for the changelog

Drop all validation for kubeletconfig

[openshift-ci-robot]

@harche: This pull request references Bugzilla bug 1923874, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1923874: KubeletConfig: Drop all validation for kubeletconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sinnykumari]

/assign @rphillips

[openshift-ci]

@harche: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-ovn-step-registry	1b009f0	link	/test e2e-ovn-step-registry
ci/prow/e2e-aws-workers-rhel7	1b009f0	link	/test e2e-aws-workers-rhel7
ci/prow/okd-e2e-aws	1b009f0	link	/test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rphillips]

/lgtm

[rphillips]

/retest

[rphillips]

/assign @sinnykumari

[sinnykumari]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@harche: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2383
• openshift/machine-config-operator#2390

Bugzilla bug 1923874 has been moved to the MODIFIED state.

In response to this:

Bug 1923874: KubeletConfig: Drop validation for kubeletconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.