New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1925319: configure-ovs: fix bash syntax error #2392
Bug 1925319: configure-ovs: fix bash syntax error #2392
Conversation
```shell if [ -z "$vlan_id"]; then ``` ``` configure-ovs-network.sh:140:5: note: The mentioned syntax error was in this if expression. [SC1009] configure-ovs-network.sh:140:8: error: Couldn't parse this test expression. Fix to allow more checks. [SC1073] configure-ovs-network.sh:140:13: error: Expected this to be an argument to the unary condition. [SC1019] configure-ovs-network.sh:140:24: error: You need a space before the ]. [SC1020] configure-ovs-network.sh:140:24: error: Missing space before ]. Fix any mentioned problems and try again. [SC1072] ```
@rbbratta: This pull request references Bugzilla bug 1925319, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rbbratta: This pull request references Bugzilla bug 1925319, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rbbratta: This pull request references Bugzilla bug 1925319, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@kikisdeliveryservice @runcom can you PTAL? |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, rbbratta, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@rbbratta: All pull requests linked via external trackers have merged: Bugzilla bug 1925319 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: 1925319
- What I did
- How to verify it
Extract inline bash configure-ovs.sh to file, run
shellcheck
on it.- Description for the changelog
Fixed bash syntax error in configure-ovs.sh