Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1933077: use environment file for proxy settings #2436

Closed
wants to merge 1 commit into from
Closed

[release-4.6] Bug 1933077: use environment file for proxy settings #2436

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2342

/assign darkmuggle

Bug 1882674: use environment file for proxy settings
cab347c 
Proxies that are url encoded represent sepcial characters with a '%'.
However, systemd uses '%' as control character in unit files and
dropins [1]. This moves the environment varialbes into a file and uses a
EnviromentFile stanza in the units which cannot safely contain '%' and
avoids adding complicated logic to the MCO for mangling the proxy
passwords (detecting if its URL encoded and special character handling).

Signed-off-by: Ben Howard <ben.howard@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1882674 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

[release-4.6] Bug 1882674: use environment file for proxy settings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign runcom after the PR has been reviewed.
You can assign the PR to them by writing /assign @runcom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@darkmuggle darkmuggle changed the title [release-4.6] Bug 1882674: use environment file for proxy settings [release-4.6] Bug 1933077: use environment file for proxy settings Feb 25, 2021
@darkmuggle
Copy link
Contributor

/hold

Dependencies for this backport are being created.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021
@darkmuggle
Copy link
Contributor

This is blocked on:
#2435

In looking at the 4.6 Templates, we will not backport separating dropins into separate files.

@kikisdeliveryservice kikisdeliveryservice added the 4.6 Work targeted for 4.6 label Feb 25, 2021
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2021
@kikisdeliveryservice
Copy link
Contributor

@darkmuggle is this still needed?

@kikisdeliveryservice kikisdeliveryservice removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2021
This was referenced Jul 1, 2021
Merged
Closed
@kikisdeliveryservice kikisdeliveryservice requested review from kikisdeliveryservice and removed request for yuqi-zhang July 14, 2021 00:08
@kikisdeliveryservice
Copy link
Contributor

@darkmuggle #2435 merged, should we get this in now?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@openshift-cherrypick-robot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2021
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel7 cab347c link /test e2e-aws-workers-rhel7
ci/prow/okd-e2e-gcp-op cab347c link /test okd-e2e-gcp-op
ci/prow/e2e-gcp-op cab347c link true /test e2e-gcp-op
ci/prow/e2e-aws cab347c link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@darkmuggle darkmuggle

Labels
4.6 Work targeted for 4.6 do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @darkmuggle @openshift-bot @kikisdeliveryservice