Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1929257: Fix 1:1 mapping for kubeletconfig:MC and some e2e test fixes #2462

Merged
merged 2 commits into from Mar 19, 2021
Merged

[release-4.7] Bug 1929257: Fix 1:1 mapping for kubeletconfig:MC and some e2e test fixes #2462

merged 2 commits into from Mar 19, 2021

Conversation

umohnani8
Copy link
Contributor

Fixes #1929257

- What I did
Fix 1:1 mapping for kubeletconfig:MC and make getting the suffix of a kubeletconfig MC more robust.
Cherry-pick of #2408 and #2459.

@umohnani8
Fix 1:1 mapping for kubeletconfig:MC and some e2e test fixes
6ab6dbb 
Minor fix in the logic for getting the suffix of the MC for a kubelet
config. Remove some extra debugs from the e2e tests.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@umohnani8
Make getting the suffix of a kubeletconfig MC more robust
43fd81e 
Instead of relying on the order in which the kubeletconfig
objects are added to the list, let's go through the
list and find the maximum suffix value used. We can
then add 1 to the max suffix value to be used for the
MC when creating the new kubeletconfig object.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Bugzilla bug 1929257, which is invalid:

  • expected dependent Bugzilla bug 1840881 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1929257: Fix 1:1 mapping for kubeletconfig:MC and some e2e test fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 15, 2021
@umohnani8 umohnani8 mentioned this pull request Mar 15, 2021
Closed
@umohnani8
Copy link
Contributor Author

/retest

@umohnani8
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 17, 2021
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Bugzilla bug 1929257, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1840881 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1840881 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @lyman9966

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Contributor Author

/retest

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@umohnani8
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sinnykumari, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@umohnani8
Copy link
Contributor Author

/skip

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2021 •
edited

@umohnani8: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-assisted 43fd81e link /test e2e-metal-assisted
ci/prow/okd-e2e-gcp-op 43fd81e link /test okd-e2e-gcp-op
ci/prow/okd-e2e-upgrade 43fd81e link /test okd-e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 09a21e1 into openshift:release-4.7 Mar 19, 2021
@openshift-ci-robot
Copy link
Contributor

@umohnani8: All pull requests linked via external trackers have merged:

Bugzilla bug 1929257 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1929257: Fix 1:1 mapping for kubeletconfig:MC and some e2e test fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@darkmuggle darkmuggle Awaiting requested review from darkmuggle

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

@lyman9966 lyman9966 Awaiting requested review from lyman9966

Assignees

@rphillips rphillips

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@umohnani8 @openshift-ci-robot @rphillips @openshift-bot @sinnykumari @ecordell @openshift-merge-robot