[release-4.6] Bug 1945544: templates: add After=ostree-finalize-staged.service to kubelet.service #2502
Conversation
We've seen occasional issues during upgrades caused by what seems to be the kubelet still being active during OSTree finalization. If the kubelet changes things in `/etc`, it'll confuse OSTree which is trying to do the `/etc` merge. We want to be sure that the kubelet is done modifying everything it needs to in `/etc` and that it exited before we finalize the deployment. Add a `After=ostree-finalize-staged.service` for this. The way this works is that that service runs in its `ExecStop`, and shutdown ordering is the reverse of startup. So this will cause the kubelet to exit before `ostree-finalize-staged.service` is stopped. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1902963
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 1936008 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
response code 502 not 200
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kikisdeliveryservice
changed the title
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-medium
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1936008, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/skip |
|
something wrong with the bz on this one.. |
sinnykumari
changed the title
openshift-ci-robot
added
bugzilla/valid-bug
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1945544, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
looks like bot didn't create corresponding 4.6 BZ. Created one. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
How do we get approval for this? I think this may help with https://bugzilla.redhat.com/show_bug.cgi?id=1915225 (see https://bugzilla.redhat.com/show_bug.cgi?id=1915225#c8). |
|
This just needs the cherry-pick-approved label, which requires a patch manager to explicitly approve for the next 4.6 release. It is mostly out of our hands unless we wish to escalate its priority (via bugzilla or elsewise) |
|
[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.
NOTE: This message was automatically generated, if you have questions please ask on #forum-release |
knobunc
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1945544 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2455
/assign yuqi-zhang