Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1949348: not allow healthcheck traffic to loop through the node #2526

Merged
merged 1 commit into from May 26, 2021
Merged

[release-4.7] Bug 1949348: not allow healthcheck traffic to loop through the node #2526

merged 1 commit into from May 26, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2477

/assign dcbw

don't forward GCP health checkers traffic
eb43d46 
The way that Openshift configures the VIPs differs from GCP, and
instead uses DNAT with conntrack.

The GCP health checkers poll the VMs with LB backends to know its
status. This traffic is wrongly DNATed sometimes, and it
create stale entries in conntrack that cause network interruptions.

The healthcheck traffic can never be forwarded inside the VM, so
we just drop it, allowing only it when is directed to the host.

Signed-off-by: Antonio Ojea <aojea@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1925698 has been cloned as Bugzilla bug 1949348. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1949348: not allow healthcheck traffic to loop through the node

In response to this:

[release-4.7] Bug 1925698: not allow healthcheck traffic to loop through the node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign ashcrow after the PR has been reviewed.
You can assign the PR to them by writing /assign @ashcrow in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1925698: not allow healthcheck traffic to loop through the node [release-4.7] Bug 1949348: not allow healthcheck traffic to loop through the node Apr 14, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1949348, which is invalid:

  • expected dependent Bugzilla bug 1925698 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1949348: not allow healthcheck traffic to loop through the node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 14, 2021
@aojea
Copy link
Contributor

aojea commented Apr 14, 2021

/retest

3 similar comments
@aojea
Copy link
Contributor

aojea commented Apr 19, 2021

/retest

@dcbw
Copy link
Contributor

dcbw commented Apr 22, 2021

/retest

@aojea
Copy link
Contributor

aojea commented May 24, 2021

/retest

@sdodson
Copy link
Member

sdodson commented May 25, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2021

@sdodson: This pull request references Bugzilla bug 1949348, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1925698 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1925698 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 25, 2021
@openshift-ci openshift-ci bot requested a review from wangke19 May 25, 2021 13:02
@aojea
Copy link
Contributor

aojea commented May 25, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@sdodson
Copy link
Member

sdodson commented May 25, 2021

/approve

@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: aojea, openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented May 25, 2021

Overriding OWNERS approval as this will improve CI health considerably.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

these three jobs are red and not-reqd skipping as this is a needed improvement

/skip

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 26, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-assisted eb43d46 link /test e2e-metal-assisted
ci/prow/okd-e2e-upgrade eb43d46 link /test okd-e2e-upgrade
ci/prow/okd-e2e-gcp-op eb43d46 link /test okd-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ac9d1db into openshift:release-4.7 May 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1949348 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1949348: not allow healthcheck traffic to loop through the node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@aojea aojea

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @aojea @dcbw @sdodson @openshift-bot @kikisdeliveryservice @openshift-merge-robot