Bug 1949387: Fix the typo in reserved calculation in auto sizing script #2527

harche · 2021-04-14T07:42:22Z

Signed-off-by: Harshal Patil harpatil@redhat.com

Fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1949387

- What I did
Fixed the typo in auto node sizing script

- How to verify it
Enable auto node sizing where getconf _NPROCESSORS_ONLN is 2, and the auto node sizing should not fail.

- Description for the changelog

Fix the typo reserved cpu calculation in auto sizing script

openshift-ci-robot · 2021-04-14T07:42:41Z

@harche: This pull request references Bugzilla bug 1949387, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1949387: Fix the typo reserved cpu calculation in auto sizing script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2021-04-14T07:43:05Z

/bugzilla refresh

openshift-ci-robot · 2021-04-14T07:43:11Z

@harche: This pull request references Bugzilla bug 1949387, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2021-04-14T08:20:24Z

/hold

Signed-off-by: Harshal Patil <harpatil@redhat.com>

harche · 2021-04-14T09:57:14Z

templates/common/_base/files/kubelet-auto-sizing.yaml

@@ -37,7 +37,7 @@ contents:
            recommended_systemreserved_memory=$(echo $recommended_systemreserved_memory 6.72 | awk '{print $1 + $2}')
            total_memory=$((total_memory-112))
        fi
-        if (($total_memory >= 128)); then # 2% of any memory above 128GB
+        if (($total_memory >= 0)); then # 2% of any memory above 128GB


this was a bug, if the memory was above 128 without this fix it will yield incorrect result.

memory reserved 128 9.32Gi 129 9.34Gi 130 9.36Gi

after 128, add 2% of the remaining memory to the reserved.

harche · 2021-04-14T09:58:58Z

templates/common/_base/files/kubelet-auto-sizing.yaml

@@ -46,15 +46,16 @@ contents:
        total_cpu=$(getconf _NPROCESSORS_ONLN)
        recommended_systemreserved_cpu=0
        if (($total_cpu <= 1)); then # 6% of the first core
-            recommended_systemreserved_cpu=$(echo $total_cpu 0.60 | awk '{print $1 * $2}')
+            recommended_systemreserved_cpu=$(echo $total_cpu 0.06 | awk '{print $1 * $2}')


A typo, we need to get 6% of the CPU. Because of the typo, it was getting 60%. However, since we never have system in CI or in production with just 1 CPU. This bug never surfaced.

harche · 2021-04-14T09:59:37Z

templates/common/_base/files/kubelet-auto-sizing.yaml

-            total_cpu=0 else
+            recommended_systemreserved_cpu=$(echo $recommended_systemreserved_cpu $(echo $total_cpu 0.01 | awk '{print $1 * $2}') | awk '{print $1 + $2}')
+            total_cpu=0
+        else


else in this line was misplaced.

Also, there was a typo on line 56 where we wanted to get 1% of CPU but we were getting 10%.

harche · 2021-04-14T10:01:02Z

templates/common/_base/files/kubelet-auto-sizing.yaml

@@ -65,7 +66,7 @@ contents:
            recommended_systemreserved_cpu=$(echo $recommended_systemreserved_cpu 0.01 | awk '{print $1 + $2}')
            total_cpu=$((total_cpu-2))
        fi
-        if (($total_cpu >= 4)); then # 0.25% of any cores above 4 cores
+        if (($total_cpu >= 0)); then # 0.25% of any cores above 4 cores


This was a bug too. Above 4 cores, without this fix we would start to slightly deviate away from the desired output.

Core Reserved Value 1 0.06 2 0.07 3 0.075 4 0.08 5 0.0825 after 4, keep adding 0.0025 for per cpu core

harche · 2021-04-14T10:20:08Z

/hold cancel

Verified with various inputs.

rphillips · 2021-04-14T12:37:34Z

/lgtm
/approve

harche · 2021-04-14T13:21:46Z

/assign @sinnykumari

sinnykumari

Not blocking the PR but writing unit test would be more appropriate way to make sure we are getting expecting result in each cases.

openshift-ci-robot · 2021-04-14T15:14:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-14T15:49:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

harche · 2021-04-14T15:52:26Z

Not blocking the PR but writing unit test would be more appropriate way to make sure we are getting expecting result in each cases.

This script is embedded in rhcos ignition file. There is no way to execute this script unless deployed on the node by the installer.

openshift-bot · 2021-04-14T17:25:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-14T17:37:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-14T18:25:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-14T18:49:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-14T19:01:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-14T19:49:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-14T21:25:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-14T22:25:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T01:01:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T01:13:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T03:02:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T03:15:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T05:18:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T05:31:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T06:49:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T07:02:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-04-15T07:21:30Z

@harche: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere-upgrade	`92b1e18`	link	`/test e2e-vsphere-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-04-15T07:28:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-04-15T08:08:42Z

@harche: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2527

Bugzilla bug 1949387 has been moved to the MODIFIED state.

In response to this:

Bug 1949387: Fix the typo in reserved calculation in auto sizing script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche changed the title ~~Fix the typo reserved cpu calculation in auto sizing script~~ Bug 1949387: Fix the typo reserved cpu calculation in auto sizing script Apr 14, 2021

openshift-ci-robot requested review from sinnykumari and yuqi-zhang April 14, 2021 07:42

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 14, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 14, 2021

harche changed the title ~~Bug 1949387: Fix the typo reserved cpu calculation in auto sizing script~~ Bug 1949387: Fix the typo in reserved cpu calculation in auto sizing script Apr 14, 2021

harche force-pushed the bug_1949387 branch from d988da0 to dd5de67 Compare April 14, 2021 07:48

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2021

Fix the typo in systemd reserved calculation in auto sizing script

92b1e18

Signed-off-by: Harshal Patil <harpatil@redhat.com>

harche force-pushed the bug_1949387 branch from dd5de67 to 92b1e18 Compare April 14, 2021 09:54

harche changed the title ~~Bug 1949387: Fix the typo in reserved cpu calculation in auto sizing script~~ Bug 1949387: Fix the typo in reserved reserved calculation in auto sizing script Apr 14, 2021

harche commented Apr 14, 2021

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2021

harche changed the title ~~Bug 1949387: Fix the typo in reserved reserved calculation in auto sizing script~~ Bug 1949387: Fix the typo in reserved calculation in auto sizing script Apr 14, 2021

openshift-ci-robot assigned rphillips Apr 14, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021

openshift-ci-robot assigned sinnykumari Apr 14, 2021

sinnykumari approved these changes Apr 14, 2021

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021

openshift-merge-robot merged commit fbc4d8e into openshift:master Apr 15, 2021

Bug 1949387: Fix the typo in reserved calculation in auto sizing script #2527

Bug 1949387: Fix the typo in reserved calculation in auto sizing script #2527

Conversation

harche commented Apr 14, 2021

openshift-ci-robot commented Apr 14, 2021

harche commented Apr 14, 2021

openshift-ci-robot commented Apr 14, 2021

harche commented Apr 14, 2021

harche Apr 14, 2021

Choose a reason for hiding this comment

harche Apr 14, 2021

Choose a reason for hiding this comment

harche Apr 14, 2021 • edited

Choose a reason for hiding this comment

harche Apr 14, 2021

Choose a reason for hiding this comment

harche Apr 14, 2021

Choose a reason for hiding this comment

harche Apr 14, 2021

Choose a reason for hiding this comment

harche Apr 14, 2021 • edited

Choose a reason for hiding this comment

harche commented Apr 14, 2021

rphillips commented Apr 14, 2021

harche commented Apr 14, 2021

sinnykumari left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

harche commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 14, 2021

openshift-bot commented Apr 15, 2021

openshift-bot commented Apr 15, 2021

openshift-bot commented Apr 15, 2021

openshift-bot commented Apr 15, 2021

openshift-bot commented Apr 15, 2021

openshift-bot commented Apr 15, 2021

openshift-bot commented Apr 15, 2021

openshift-bot commented Apr 15, 2021

openshift-ci bot commented Apr 15, 2021 • edited

openshift-bot commented Apr 15, 2021

openshift-ci-robot commented Apr 15, 2021

harche Apr 14, 2021 •

edited

harche Apr 14, 2021 •

edited

openshift-ci bot commented Apr 15, 2021 •

edited