Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1948533: Add nodeip-configuration.service for oVirt #2567

Merged
merged 1 commit into from May 13, 2021
Merged

Bug 1948533: Add nodeip-configuration.service for oVirt #2567

merged 1 commit into from May 13, 2021

Conversation

Gal-Zaidman
Copy link
Contributor

- What I did

This change adds the nodeip-configuration.service to the oVirt platform.
On 4.7 due to the unification of the unit files of each on prem platform to the "on-prem" directory oVirt got the "nodeip-configuration.service" file but on 4.6 release we are missing it which can cause hard to debug problems to customers.

This change also adds fixes for BZ#1940939 #2470

** I was not able to reproduce the issue on BZ#1948533 but this change seems relevant and according to the comments on BZ#1948533 will fix the issues

- How to verify it
Install a 4.6 ovirt cluster

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 5, 2021
@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: This pull request references Bugzilla bug 1948533, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "---" instead
  • expected Bugzilla bug 1948533 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1948533: Add nodeip-configuration.service for oVirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 5, 2021
@Gal-Zaidman
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: This pull request references Bugzilla bug 1948533, which is invalid:

  • expected Bugzilla bug 1948533 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link
Contributor Author

/hold

For tests

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2021
@Gal-Zaidman
Copy link
Contributor Author

/test ?

@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: The following commands are available to trigger jobs:

  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-gcp-op
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test images
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-release-4.6-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.6-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.6-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-release-4.6-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.6-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-release-4.6-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-release-4.6-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.6-images
  • pull-ci-openshift-machine-config-operator-release-4.6-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.6-okd-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.6-okd-e2e-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.6-okd-images
  • pull-ci-openshift-machine-config-operator-release-4.6-unit
  • pull-ci-openshift-machine-config-operator-release-4.6-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link
Contributor Author

/test e2e-ovirt

@Gal-Zaidman
Copy link
Contributor Author

/retest

@hardys hardys mentioned this pull request May 5, 2021
Closed
@Gal-Zaidman
Copy link
Contributor Author

/unhold

oVirt job passed

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2021
@Gal-Zaidman
Copy link
Contributor Author

/assign @runcom

patrickdillon
patrickdillon reviewed May 5, 2021
View reviewed changes
templates/common/ovirt/units/nodeip-configuration.service.yaml Outdated
@@ -0,0 +1,48 @@
name: nodeip-configuration.service
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to disable this service in the case of a UPI install? That is what we do for vSphere, but not sure if applicable for your case: https://github.com/openshift/machine-config-operator/blob/release-4.6/templates/common/vsphere/units/nodeip-configuration.service.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for the review,
I added the enabled logic but removed the ifs from the "contents" since I think that if the service is disabled it doesn't matter

@patrickdillon
Copy link
Contributor

Fixes #2529

@yuqi-zhang
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 6, 2021
@openshift-ci-robot
Copy link
Contributor

@yuqi-zhang: This pull request references Bugzilla bug 1948533, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1957530 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1957530 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 6, 2021
yuqi-zhang
yuqi-zhang approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM pending Patrick's comment. Will also let him do the final lgtm when ready

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gal-Zaidman, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

24 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@Gal-Zaidman: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-gcp-op fa23954 link /test okd-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2ea67ec into openshift:release-4.6 May 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@Gal-Zaidman: All pull requests linked via external trackers have merged:

Bugzilla bug 1948533 has been moved to the MODIFIED state.

In response to this:

Bug 1948533: Add nodeip-configuration.service for oVirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@runcom runcom

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Gal-Zaidman @openshift-ci-robot @patrickdillon @yuqi-zhang @openshift-bot @mrunalp @runcom @openshift-merge-robot