Add Dockerfile for proxy test image #2602
Conversation
|
Is there any background for this? I have no real idea why this is being done. cc: @rphillips do you have any details? |
| @@ -0,0 +1,2 @@ | |||
| FROM registry.redhat.io/rhel7:latest | |||
| LABEL io.openshift.release.operator true | |||
There was a problem hiding this comment.
We should add a file into the image to say what this is being used for. This will also make the image hash unique.
There was a problem hiding this comment.
Add a readme file under docs/, does this make sense?
|
@kikisdeliveryservice This is for the epic to test proxy access via the MCO. Qi will link the Jira for it. |
QiWang19
force-pushed
the
proxy-dockerfile
branch
from
a41395a
to
f5d5e93
Compare
|
LGTM, based on Jira card and README attached. |
|
/retest |
Yes, we need this for 4.9. This PR will be part of work to close Bug 1928581 https://bugzilla.redhat.com/show_bug.cgi?id=1928581 |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
|
/retest |
docs/openshift-proxy-pull-test.md
Outdated
| @@ -0,0 +1 @@ | |||
| The Dockerfile.proxy builds the openshift-proxy-pull-test image. If the http proxy is set by controller config, [MCO](https://github.com/openshift/machine-config-operator) will validate the proxy by pulling this image through the proxy. The proxy is valid, if the image can be successfully pulled. | |||
There was a problem hiding this comment.
| The Dockerfile.proxy builds the openshift-proxy-pull-test image. If the http proxy is set by controller config, [MCO](https://github.com/openshift/machine-config-operator) will validate the proxy by pulling this image through the proxy. The proxy is valid, if the image can be successfully pulled. | |
| The Dockerfile.proxy builds the openshift-proxy-pull-test image. If the http proxy is set by controller config, [MCO](https://github.com/openshift/machine-config-operator) will validate the proxy by pulling this image through the proxy. The proxy is valid if the image can be successfully pulled. |
This image will be added into the ocp-build-data(https://github.com/openshift/ocp-build-data) repository. So product MCO(https://github.com/openshift/machine-config-operator) can pull the image through a proxy that the customer configured to validate the proxy. Signed-off-by: Qi Wang <qiwan@redhat.com>
QiWang19
force-pushed
the
proxy-dockerfile
branch
from
f5d5e93
to
12ab4a6
Compare
|
Since master is open for 4.9 lgtm. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@kikisdeliveryservice PTAL. I cleaned the review. Could you tag lgtm? |
|
I'd like @rphillips to give the final once over and to verify that the doc is what he had in mind /assign @rphillips |
|
/retest |
|
yep. this works for me. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, QiWang19, rphillips, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This image will be added into the ocp-build-data(https://github.com/openshift/ocp-build-data)
repository. So product MCO(https://github.com/openshift/machine-config-operator) can
pull the image through a proxy that the customer configured to validate the proxy.
Ticket for the image build request: https://issues.redhat.com/browse/ART-2961
Signed-off-by: Qi Wang qiwan@redhat.com
- What I did
- How to verify it
- Description for the changelog