[release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval

[rvanderp3]

Fixes: BZ1927555 - when creating a new machine, the node will get an unexpected hostname

Note: This pull-request is a replacement for PR 2404. A problem was found in release-4.7 which required a change to PR 2404.

• What I did
  Added the --static flag to hostnamectl to prevent DHCP from overriding the hostname sourced from guestinfo.

• How to verify it

Configure DHCP to assign a hostname as part of the lease
Scale a new node
The node should automatically join the cluster with a node name like --worker-

• Description for the changelog
  Resolves issue where the hostname provided by the DHCP overrides the guestinfo hostname thus preventing the machine-api-controller from reconciling new nodes which receive a hostname from DHCP.

[openshift-ci]

@rvanderp3: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

set hostname statically if hostname configured in guestinfo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rvanderp3]

cc @jcpowermac

[openshift-ci]

@rvanderp3: This pull request references Bugzilla bug 1927555, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1927783 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1927783 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

[release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rvanderp3: This pull request references Bugzilla bug 1927555, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1927783 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1927783 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

[release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rvanderp3]

/test e2e-vsphere

[rvanderp3]

/test e2e-vsphere

[jcpowermac]

/lgtm

e2e-vsphere is hitting docker rate limiting but is installing correctly

[kikisdeliveryservice]

@rvanderp3 since this only affect vsphere templates, someone from the vsphere owners should be able to approve:

machine-config-operator/OWNERS_ALIASES

Line 36 in b2fec38

vsphere-approvers:

[jcpowermac]

/approve

[kikisdeliveryservice]

doh i guess the owners file is by version too 😦

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, kikisdeliveryservice, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@rvanderp3: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-ovn-step-registry	5e9c329	link	/test e2e-ovn-step-registry
ci/prow/e2e-vsphere	5e9c329	link	/test e2e-vsphere
ci/prow/okd-e2e-gcp-op	5e9c329	link	/test okd-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mfojtik]

[patch-manager] 🚀 Approved for z-stream by score: 0.70

approved

[openshift-ci]

@rvanderp3: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2615

Bugzilla bug 1927555 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1927555: [vsphere] set hostname with --static to provide consistent node name for CSR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.