Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1975174: configure-ovs: fix nondeterministic master in slave profiles #2640

Merged
merged 7 commits into from Nov 3, 2021
Merged

[release-4.7] Bug 1975174: configure-ovs: fix nondeterministic master in slave profiles #2640

merged 7 commits into from Nov 3, 2021

Conversation

jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Jun 25, 2021 •
edited

Cherry-pick of #2626 & #2643 & #2706 & #2704 & #2512 & #2645 & #2468

- What I did

- How to verify it

- Description for the changelog

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@jcaamano: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] configure-ovs: fix nondeterministic master in slave profiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano jcaamano changed the title [release-4.7] configure-ovs: fix nondeterministic master in slave profiles [release-4.7] Bug 1975174: configure-ovs: fix nondeterministic master in slave profiles Jun 25, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@jcaamano: This pull request references Bugzilla bug 1975174, which is invalid:

  • expected dependent Bugzilla bug 1971715 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1976110 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1975171 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (DUPLICATE) instead
  • expected dependent Bugzilla bug 1971715 to target a release in 4.8.0, but it targets "4.9.0" instead
  • expected dependent Bugzilla bug 1975171 to target a release in 4.8.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1975174: configure-ovs: fix nondeterministic master in slave profiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2021
@jcaamano
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@jcaamano: This pull request references Bugzilla bug 1975174, which is invalid:

  • expected dependent Bugzilla bug 1976110 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2021

@jcaamano: This pull request references Bugzilla bug 1975174, which is invalid:

  • expected dependent Bugzilla bug 1976110 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1976110 to target a release in 4.8.0, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1975174: configure-ovs: fix nondeterministic master in slave profiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano jcaamano force-pushed the release-4.7 branch 5 times, most recently from d8f37d9 to 573162f Compare July 1, 2021 08:57
@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 1, 2021

/retest

1 similar comment
@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 2, 2021

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2021
@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 2, 2021

/retest

@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 6, 2021

/retest

4 similar comments
@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 6, 2021

/retest

@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 7, 2021

/retest

@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 7, 2021

/retest

@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 8, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

22 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sinnykumari
Copy link
Contributor

This PR needs cherry-pick approved label. @jcaamano can you please check with your QE if they are fine with this PR and then I will try to get the approval from someone who can add this label.
/skip

Ideally we should add one (max two) QE and dev from each team who contributes to this repo so that SME can assess the disk better. Going to get this fixed soon.

@stleerh
Copy link

stleerh commented Nov 1, 2021

This PR needs cherry-pick approved label. @jcaamano can you please check with your QE if they are fine with this PR and then I will try to get the approval from someone who can add this label. /skip

Ideally we should add one (max two) QE and dev from each team who contributes to this repo so that SME can assess the disk better. Going to get this fixed soon.

I had a review comment on line 312 in templates/common/_base/files/configure-ovs-network.yaml which is why I did not add the cherry-pick-approved label.

new_conn_file="${old_conn_file/${NM_CONN_PATH}\/$old_basename/${NM_CONN_PATH}/ovs-if-br-ex}"

It seems the backslash (\) in the line above will cause problems.

@jcaamano
Copy link
Contributor Author

jcaamano commented Nov 2, 2021

This PR needs cherry-pick approved label. @jcaamano can you please check with your QE if they are fine with this PR and then I will try to get the approval from someone who can add this label. /skip
Ideally we should add one (max two) QE and dev from each team who contributes to this repo so that SME can assess the disk better. Going to get this fixed soon.

I had a review comment on line 312 in templates/common/_base/files/configure-ovs-network.yaml which is why I did not add the cherry-pick-approved label.

new_conn_file="${old_conn_file/${NM_CONN_PATH}\/$old_basename/${NM_CONN_PATH}/ovs-if-br-ex}"

It seems the backslash (\) in the line above will cause problems.

Sorry, I missed the comment. I have answered it with an explanation but I am not aware of the problems the backslash causes. Could you please let me know @stleerh ?

@rbbratta
Copy link
Contributor

rbbratta commented Nov 3, 2021

This PR needs cherry-pick approved label. @jcaamano can you please check with your QE if they are fine with this PR and then I will try to get the approval from someone who can add this label. /skip
Ideally we should add one (max two) QE and dev from each team who contributes to this repo so that SME can assess the disk better. Going to get this fixed soon.

I had a review comment on line 312 in templates/common/_base/files/configure-ovs-network.yaml which is why I did not add the cherry-pick-approved label.

new_conn_file="${old_conn_file/${NM_CONN_PATH}\/$old_basename/${NM_CONN_PATH}/ovs-if-br-ex}"

It seems the backslash (\) in the line above will cause problems.

I don't seen any issue in the bash trace from the logs.

7:Nov 02 15:25:34 control-plane-1 configure-ovs.sh[1335]: + NM_CONN_PATH=/etc/NetworkManager/systemConnectionsMerged
--
185-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + echo 'WARN: unable to find NM configuration file for conn: 702de3eb-2e80-897c-fd52-cd0494dd8123. Attempting to clone conn'
186-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: WARN: unable to find NM configuration file for conn: 702de3eb-2e80-897c-fd52-cd0494dd8123. Attempting to clone conn
187-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + nmcli conn clone 702de3eb-2e80-897c-fd52-cd0494dd8123 702de3eb-2e80-897c-fd52-cd0494dd8123-clone
188-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: team0 (702de3eb-2e80-897c-fd52-cd0494dd8123) cloned as 702de3eb-2e80-897c-fd52-cd0494dd8123-clone (030bfb8d-7370-4974-85ae-dd2f2c2647ba).
189-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + shopt -s nullglob
190:Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + old_conn_files=(${NM_CONN_PATH}/"${old_conn}"-clone*)
191-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + shopt -u nullglob
192-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + '[' 1 -ne 1 ']'
193:Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + old_conn_file=/etc/NetworkManager/systemConnectionsMerged/702de3eb-2e80-897c-fd52-cd0494dd8123-clone.nmconnection
--
196-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: Successfully cloned conn to /etc/NetworkManager/systemConnectionsMerged/702de3eb-2e80-897c-fd52-cd0494dd8123-clone.nmconnection
197-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + echo 'old connection file found at: /etc/NetworkManager/systemConnectionsMerged/702de3eb-2e80-897c-fd52-cd0494dd8123-clone.nmconnection'
198-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: old connection file found at: /etc/NetworkManager/systemConnectionsMerged/702de3eb-2e80-897c-fd52-cd0494dd8123-clone.nmconnection
199-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: ++ basename /etc/NetworkManager/systemConnectionsMerged/702de3eb-2e80-897c-fd52-cd0494dd8123-clone.nmconnection .nmconnection
200-Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + old_basename=702de3eb-2e80-897c-fd52-cd0494dd8123-clone
201:Nov 02 15:25:36 control-plane-1 configure-ovs.sh[1335]: + new_conn_file=/etc/NetworkManager/systemConnectionsMerged/ovs-if-br-ex.nmconnection

vSphere 4.7 UPI teaming ifcfg static-ip
http://file.rdu.redhat.com/~rbrattai/logs/syslog-172.31.248.35

@stleerh stleerh added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 04bcf9c into openshift:release-4.7 Nov 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

@jcaamano: All pull requests linked via external trackers have merged:

Bugzilla bug 1975174 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1975174: configure-ovs: fix nondeterministic master in slave profiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliurh pliurh pliurh left review comments

@stleerh stleerh stleerh left review comments

@sinnykumari sinnykumari sinnykumari approved these changes

@rbbratta rbbratta Awaiting requested review from rbbratta

Assignees

@kikisdeliveryservice kikisdeliveryservice

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet