docs: update doc for conditional no drain during ICSP changes #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
This covers changes made in #2596 |
yuqi-zhang
reviewed
Jun 30, 2021
docs/MachineConfigDaemon.md
Outdated
| @@ -157,12 +157,16 @@ The updated list of optimized updates and behaviour (as of Openshift 4.8) is as | |||
| 1. [SSH Keys](./Update-SSHKeys.md) (updating ignition/passwd/users/sshAuthorizedKeys section in a MachineConfig) | |||
| 2. kube-apiserver-to-kubelet-signer CA cert (located at `/etc/kubernetes/kubelet-ca.crt`, 1 year expiry autorotated by the openshift-kubeapiserver operator) | |||
| 3. [Pull Secret](./PullSecret.md) (cluster-wide, located at `/var/lib/kubelet/config.json`). | |||
| 4. **Selected registries.conf changes(/etc/containers/registries.conf, e.g. ICSP changes)** It can only include following changes in registries.conf file: | |||
There was a problem hiding this comment.
Maybe something like: Selected registries.conf changes(/etc/containers/registries.conf, e.g. ICSP changes) -> Select registries.conf changes(/etc/containers/registries.conf. This file is generally changed via ICSP object changes. Only the following changes will cause no-reboot upgrades
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sinnykumari, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.