Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1982052: Handle team/bond interfaces with a more clear message #2676

Merged
merged 1 commit into from Jul 17, 2021
Merged

Bug 1982052: Handle team/bond interfaces with a more clear message #2676

merged 1 commit into from Jul 17, 2021

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jul 14, 2021

When teamed/bonded interfaces are presented to the ovs-configure
script, the uevent file doesn't exist under the device dir because
there is no actual net-device corresponding to the bond. This
commit adds a more clear error message for handling team/bonded
interfaces.

Signed-off-by: Aniket Bhat anbhat@redhat.com

@abhat
Handle team/bond interfaces with a more clear message
809d98c 
When teamed/bonded interfaces are presented to the ovs-configure
script, the uevent file doesn't exist under the device dir because
there is no actual net-device corresponding to the bond. This
commit adds a more clear error message for handling team/bonded
interfaces.

Signed-off-by: Aniket Bhat <anbhat@redhat.com>
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@abhat: This pull request references Bugzilla bug 1982052, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rbrattai@redhat.com), skipping review request.

In response to this:

Bug 1982052: Handle team/bond interfaces with a more clear message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 14, 2021
@kikisdeliveryservice
Copy link
Contributor

/assign @trozet

trozet
trozet reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhat one question, do we need to set the allmulti on the slaves if they are using vmxnet3 driver or no?

@abhat
Copy link
Contributor Author

abhat commented Jul 16, 2021

From what @rbbratta mentioned it's working without setting the allmulti option on the bonded interfaces. So I feel like just sipping the bond/team interface is sufficient.

@trozet
Copy link
Contributor

trozet commented Jul 16, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2021
@trozet
Copy link
Contributor

trozet commented Jul 16, 2021

/assign sinnykumari

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, kikisdeliveryservice, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2021 •
edited

@abhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovn-step-registry 809d98c link /test e2e-ovn-step-registry
ci/prow/e2e-aws-disruptive 809d98c link /test e2e-aws-disruptive
ci/prow/e2e-aws-workers-rhel7 809d98c link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-upgrade-single-node 809d98c link /test e2e-aws-upgrade-single-node
ci/prow/okd-e2e-aws 809d98c link /test okd-e2e-aws
ci/prow/e2e-gcp-op-single-node 809d98c link /test e2e-gcp-op-single-node
ci/prow/e2e-vsphere-upgrade 809d98c link /test e2e-vsphere-upgrade
ci/prow/e2e-metal-ipi 809d98c link /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9b53676 into openshift:master Jul 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2021

@abhat: All pull requests linked via external trackers have merged:

Bugzilla bug 1982052 has been moved to the MODIFIED state.

In response to this:

Bug 1982052: Handle team/bond interfaces with a more clear message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@sinnykumari sinnykumari

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abhat @kikisdeliveryservice @trozet @openshift-bot @sinnykumari @openshift-merge-robot