New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: Explicitly start rpm-ostreed, restart if we detect active txn #2677
daemon: Explicitly start rpm-ostreed, restart if we detect active txn #2677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions :)
e0a072b
to
b3a3316
Compare
This is a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1982389 which is already fixed in rpm-ostree in coreos/rpm-ostree#2995 because it will take a fair while until we can ship the fixed rpm-ostreed in RHEL and then OpenShift stable versions. (Yes, this is a sad recurring pattern) The updater client gains an explicit `Initialize` method, where we also explicitly `systemctl start rpm-ostreed` which then effectively rolls in the change from coreos/rpm-ostree#2945 too.
b3a3316
to
8c87cac
Compare
Thanks Colin! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/cherrypick release-4.8 |
@cgwalters: #2677 failed to apply on top of branch "release-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1982389
which is already fixed in rpm-ostree in
coreos/rpm-ostree#2995
because it will take a fair while until we can ship the fixed
rpm-ostreed in RHEL and then OpenShift stable versions.
(Yes, this is a sad recurring pattern)
The updater client gains an explicit
Initialize
method, wherewe also explicitly
systemctl start rpm-ostreed
whichthen effectively rolls in the change from
coreos/rpm-ostree#2945
too.