Add CRI-O metrics collectors configuration #2678
Conversation
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Do we also need add the same to |
We now can configure metrics by referencing the collector since cri-o/cri-o#5061 has been merged. This patch adds the default CRI-O metrics collectors and reflects the previously overwritten state from the Cluster Monitoring Operator (CMO). Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
crio-metrics-collectors
branch
from
6c4a39d
to
e785649
Compare
Yes, sure. Thank you for the hint. Updated the PR as suggested. |
|
As MCO doesn't own these templates, would like one of the SMEs to look: /assign @umohnani8 @mtrmac @haircommander |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kikisdeliveryservice, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@saschagrunert: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- What I did
We now can configure metrics by referencing the collector since
cri-o/cri-o#5061 has been merged.
This patch adds the default CRI-O metrics collectors and reflects the
previously overwritten state from the Cluster Monitoring Operator (CMO).
- How to verify it
Verify that the configured metrics are being served.
- Description for the changelog
Added CRI-O
metrics_collectorsconfiguration.