Bug 1982766: [on-prem] Make ingress VIP more tolerant to failures

[mandre]

We've noticed that the ingress VIP could be flapping in some
environments where the keepalived check fails due to timeout. We should
make the ingress check more resilient to errors and start using fall
and raise to mitigate flapping as we did for the API checks.

[openshift-ci]

@mandre: This pull request references Bugzilla bug 1982766, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

In response to this:

Bug 1982766: [on-prem] Make ingress VIP more tolerant to failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mandre]

/cc @cybertron @yboaron
It seems like a sensible thing to add fall and raise directives to the ingress checks like we do on the API check and I was wondering if this was something that has previously been discussed and discarded or just an overlook. Reviews welcome :)

[cybertron]

/lgtm

Agreed, this seems quite reasonable.

/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/cc @Gal-Zaidman @jcpowermac @patrickdillon

[mandre]

/retest

[openshift-ci]

@mandre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	881f3b0	link	/test e2e-aws-workers-rhel7
ci/prow/e2e-aws-techpreview-featuregate	881f3b0	link	/test e2e-aws-techpreview-featuregate
ci/prow/e2e-aws-single-node	881f3b0	link	/test e2e-aws-single-node
ci/prow/e2e-ovn-step-registry	881f3b0	link	/test e2e-ovn-step-registry
ci/prow/e2e-aws-disruptive	881f3b0	link	/test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jcpowermac]

/lgtm

[mandre]

As the bot suggests.
/assign sinnykumari

All relevant jobs are passing, PTAL.

[sinnykumari]

All relevant tests are passing.

[Gal-Zaidman]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, Gal-Zaidman, jcpowermac, mandre, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@mandre: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2679

Bugzilla bug 1982766 has been moved to the MODIFIED state.

In response to this:

Bug 1982766: [on-prem] Make ingress VIP more tolerant to failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.