Bug 1986437: Bump github.com/openshift/api #2685

Fedosin · 2021-07-20T17:45:14Z

This change includes an important update for ExternalCloudProvider feature gate: openshift/api#961

Generated by go get -u github.com/openshift/api + go mod vendor

elmiko · 2021-07-20T18:26:29Z

+1, this is needed to help the external cloud controller manager effort

sinnykumari · 2021-07-21T08:34:33Z

You need to update openshift/api version at https://github.com/openshift/machine-config-operator/blob/master/go.mod#L70

Q. There seems to be lot of deps update, are they all result of just updating openshift/api to 20210720160326-96bb0f993a66 ?

Fedosin · 2021-07-21T10:50:16Z

/retest

Fedosin · 2021-07-21T11:12:20Z

@sinnykumari unfortunately now one of our dependencies is broken (klog) For more information: kubernetes/klog#253
So, this PR does two things: first it fixes the issue with klog, and then bumps openshift/api. For clarity I can split this PR into two commits.

Fedosin · 2021-07-21T11:31:41Z

Without additional changes it looks like this:

❯ go get -u github.com/openshift/api
# k8s.io/klog/v2
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:705:10: invalid operation: logr != nil (mismatched types logr.Logger and nil)
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:724:10: invalid operation: logr != nil (mismatched types logr.Logger and nil)
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:742:10: invalid operation: logr != nil (mismatched types logr.Logger and nil)
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:763:10: invalid operation: logr != nil (mismatched types logr.Logger and nil)
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:782:11: invalid operation: loggr != nil (mismatched types logr.Logger and nil)
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:783:3: undefined: logr.WithCallDepth
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:794:11: invalid operation: loggr != nil (mismatched types logr.Logger and nil)
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:795:3: undefined: logr.WithCallDepth
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:915:9: invalid operation: log != nil (mismatched types logr.Logger and nil)
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:919:4: undefined: logr.WithCallDepth
../../go/pkg/mod/k8s.io/klog/v2@v2.10.0/klog.go:919:4: too many errors

sinnykumari · 2021-07-21T15:14:22Z

@sinnykumari unfortunately now one of our dependencies is broken (klog) For more information: kubernetes/klog#253
So, this PR does two things: first it fixes the issue with klog, and then bumps openshift/api. For clarity I can split this PR into two commits.

yes, splitting the commit makes more sense here.

kikisdeliveryservice · 2021-07-22T19:17:43Z

/test e2e-metal-ipi
/test e2e-ovn-step-registry

kikisdeliveryservice · 2021-07-22T19:21:12Z

Q: do we have anything tracking: kubernetes/klog#242 to remove that commit once that pr merges?

kikisdeliveryservice · 2021-07-22T20:41:00Z

/test e2e-ovn-step-registry
/test e2e-aws-upgrade-single-node

sinnykumari · 2021-07-23T08:18:48Z

In go.mod, you haven't updated replace section with updated versions of deps and as a result vendor file for deps like openshift/api, k8s.io/api, etc has not been pulled in. You would want to update deps mentioned in replace section so that it doesn't replace back to old one.

openshift-ci · 2021-07-27T14:52:52Z

@Fedosin: This pull request references Bugzilla bug 1986437, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 1986437: Bump github.com/openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sinnykumari · 2021-07-28T09:16:55Z

I think you are getting confused when updating replace section. You should only update deps version in replace section of go.mod that actually has corresponding changes in this PR in require section of go.mod. See https://golang.org/ref/mod#go-mod-file-replace

go.mod

Now we can't bump any dependency because of the issue in klog: kubernetes/klog#253 To workaround it's recommended to replace github.com/go-logr/logr in go.mod until the fix is released.

This change includes an important update for ExternalCloudProvider feature gate: openshift/api#961

JoelSpeed

Go mod changes LGTM now, thanks @Fedosin
/lgtm

openshift-ci · 2021-08-12T08:49:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, JoelSpeed, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-12T11:16:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T11:28:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T11:40:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T12:16:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T13:06:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T14:21:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T14:46:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T20:07:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T20:20:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T20:59:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-12T21:12:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Fedosin · 2021-08-12T23:20:04Z

/retest-required

openshift-bot · 2021-08-13T00:12:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T00:51:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T02:22:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T03:11:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T03:35:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T05:47:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T08:59:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T21:07:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T21:20:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T23:35:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-13T23:47:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-14T00:53:39Z

@Fedosin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-techpreview-featuregate	`ef46748`	link	`/test e2e-aws-techpreview-featuregate`
ci/prow/e2e-aws-workers-rhel7	`ef46748`	link	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-ovn-step-registry	`ef46748`	link	`/test e2e-ovn-step-registry`
ci/prow/e2e-aws-disruptive	`ef46748`	link	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-upgrade-single-node	`ef46748`	link	`/test e2e-aws-upgrade-single-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-14T02:13:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-14T02:26:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-14T03:42:21Z

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 1986437 has been moved to the MODIFIED state.

In response to this:

Bug 1986437: Bump github.com/openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from kikisdeliveryservice and sinnykumari July 20, 2021 17:45

Fedosin force-pushed the bump_api branch from 78d07f6 to 23597a8 Compare July 22, 2021 16:44

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2021

Fedosin force-pushed the bump_api branch from 23597a8 to 95f3579 Compare July 27, 2021 14:51

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021

Fedosin changed the title ~~Bump github.com/openshift/api~~ Bug 1986437: Bump github.com/openshift/api Jul 27, 2021

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 27, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 27, 2021

openshift-ci bot requested a review from sunzhaohua2 July 27, 2021 14:52

Fedosin force-pushed the bump_api branch from 95f3579 to 3c023be Compare July 27, 2021 14:56

openshift-ci bot mentioned this pull request Jul 28, 2021

Bug 1986437: Bump github.com/openshift/api openshift/cluster-kube-controller-manager-operator#551

Merged

aojea reviewed Jul 28, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Fedosin force-pushed the bump_api branch from 3c023be to 1c4c491 Compare August 2, 2021 11:42

Fedosin added 2 commits August 11, 2021 16:55

Fix a dependecy issue with klog

67d2ca8

Now we can't bump any dependency because of the issue in klog: kubernetes/klog#253 To workaround it's recommended to replace github.com/go-logr/logr in go.mod until the fix is released.

Bump github.com/openshift/api

ef46748

This change includes an important update for ExternalCloudProvider feature gate: openshift/api#961

Fedosin force-pushed the bump_api branch from 1c4c491 to ef46748 Compare August 11, 2021 15:00

JoelSpeed approved these changes Aug 11, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021

openshift-ci bot merged commit ff908d9 into openshift:master Aug 14, 2021

Bug 1986437: Bump github.com/openshift/api #2685

Bug 1986437: Bump github.com/openshift/api #2685

Conversation

Fedosin commented Jul 20, 2021 • edited

elmiko commented Jul 20, 2021

sinnykumari commented Jul 21, 2021

Fedosin commented Jul 21, 2021

Fedosin commented Jul 21, 2021

Fedosin commented Jul 21, 2021

sinnykumari commented Jul 21, 2021

kikisdeliveryservice commented Jul 22, 2021

kikisdeliveryservice commented Jul 22, 2021 • edited

kikisdeliveryservice commented Jul 22, 2021

sinnykumari commented Jul 23, 2021

openshift-ci bot commented Jul 27, 2021

sinnykumari commented Jul 28, 2021

JoelSpeed left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

openshift-bot commented Aug 12, 2021

Fedosin commented Aug 12, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-bot commented Aug 13, 2021

openshift-ci bot commented Aug 14, 2021 • edited

openshift-bot commented Aug 14, 2021

openshift-bot commented Aug 14, 2021

openshift-ci bot commented Aug 14, 2021

Fedosin commented Jul 20, 2021 •

edited

kikisdeliveryservice commented Jul 22, 2021 •

edited

openshift-ci bot commented Aug 14, 2021 •

edited