Bug 1988102: [release-4.7] On-prem: add default ingress track script to Keepalived #2697

yboaron · 2021-07-29T16:09:47Z

Ingress VIP should be set only on a node that runs an instance of
the default ingress controller pod.
In current code, in case extra ingress-controllers are created the
ingress VIP might be wrongly set on a node that doesn't run an instance of
the default ingress controller.

This PR adds a Keepalived track_script that should update the priority based on the
existence of a default ingress pod on the node.

openshift-ci · 2021-07-29T16:09:48Z

@yboaron: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] On-prem: add default ingress track script to Keepalived

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yboaron · 2021-07-29T17:33:40Z

/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere

cybertron · 2021-07-29T18:17:38Z

/lgtm

cybertron · 2021-07-29T18:26:07Z

/retitle Bug 1988102: [release-4.7] On-prem: add default ingress track script to Keepalived

openshift-ci · 2021-07-29T18:26:20Z

@yboaron: This pull request references Bugzilla bug 1988102, which is invalid:

expected the bug to target the "4.7.z" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1988102: [release-4.7] On-prem: add default ingress track script to Keepalived

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cybertron · 2021-07-29T18:28:11Z

/bugzilla refresh

openshift-ci · 2021-07-29T18:28:19Z

@cybertron: This pull request references Bugzilla bug 1988102, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1886572 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1886572 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rioliu@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2021-07-29T21:04:57Z

/retest

yboaron · 2021-08-01T14:21:38Z

/retest

yboaron · 2021-08-01T14:23:31Z

/cc @mandre @Gal-Zaidman @jcpowermac @patrickdillon

mandre · 2021-08-02T07:22:34Z

What's the preference for backporting patches that took multiple PRs to land in master? Here the second commit completely undoes the first commit, I'd personally prefer you squash the two commits into one and keep a clean history, however I'm not a maintainer here so my opinion probably doesn't matter that much 😄

It's also a bit odd to backport a merge commit. You should cherry-pick the original commits IMO.

Ingress VIP should be set only on a node that runs an instance of the default ingress controller pod. In current code, in case extra ingress-controllers are created the ingress VIP might be wrongly set on a node that doesn't run an instance of the default ingress controller. This PR adds a Keepalived track_script that should update the priority based on the existence of a default ingress pod on the node.

openshift-bot · 2021-08-23T13:08:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-23T13:21:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

yboaron · 2021-08-26T08:40:48Z

/retest-required

yboaron · 2021-08-26T14:22:28Z

/retest-required

openshift-bot · 2021-08-27T02:34:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T02:58:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T04:58:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T05:10:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T06:22:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T06:34:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T07:10:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T09:34:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T09:46:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T09:58:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T10:10:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T17:31:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T20:15:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T21:07:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T21:46:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T21:59:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-27T22:43:02Z

@yboaron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-assisted	`916f1da`	link	`/test e2e-metal-assisted`
ci/prow/e2e-ovn-step-registry	`916f1da`	link	`/test e2e-ovn-step-registry`
ci/prow/e2e-aws-serial	`916f1da`	link	`/test e2e-aws-serial`
ci/prow/okd-e2e-gcp-op	`916f1da`	link	`/test okd-e2e-gcp-op`
ci/prow/okd-e2e-upgrade	`916f1da`	link	`/test okd-e2e-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-27T22:51:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T23:30:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-27T23:43:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-28T00:35:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-28T00:48:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-28T01:04:00Z

@yboaron: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2697

Bugzilla bug 1988102 has been moved to the MODIFIED state.

In response to this:

Bug 1988102: [release-4.7] On-prem: add default ingress track script to Keepalived

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from adduarte and Fedosin July 29, 2021 16:10

openshift-ci bot assigned cybertron Jul 29, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021

openshift-ci bot changed the title ~~[release-4.7] On-prem: add default ingress track script to Keepalived~~ Bug 1988102: [release-4.7] On-prem: add default ingress track script to Keepalived Jul 29, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 29, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 29, 2021

openshift-ci bot requested review from Gal-Zaidman, jcpowermac, mandre and patrickdillon August 1, 2021 14:23

yboaron force-pushed the ingress_keepalived branch from eac8c1b to cfe3aad Compare August 2, 2021 10:08

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2021

yboaron force-pushed the ingress_keepalived branch 2 times, most recently from 6769fe3 to 8f36f1b Compare August 2, 2021 10:13

yboaron force-pushed the ingress_keepalived branch from 8f36f1b to 916f1da Compare August 2, 2021 10:17

jupierce added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 27, 2021

openshift-merge-robot merged commit d6d26e1 into openshift:release-4.7 Aug 28, 2021

openshift-ci bot mentioned this pull request Dec 1, 2021

[release-4.7] Bug 1988102: [IPI ON-PREM] move Keepalived default ingress script to separate file #2825

Merged

Bug 1988102: [release-4.7] On-prem: add default ingress track script to Keepalived #2697

Bug 1988102: [release-4.7] On-prem: add default ingress track script to Keepalived #2697

Conversation

yboaron commented Jul 29, 2021

openshift-ci bot commented Jul 29, 2021

yboaron commented Jul 29, 2021

cybertron commented Jul 29, 2021

cybertron commented Jul 29, 2021

openshift-ci bot commented Jul 29, 2021

cybertron commented Jul 29, 2021

openshift-ci bot commented Jul 29, 2021

kikisdeliveryservice commented Jul 29, 2021

yboaron commented Aug 1, 2021

yboaron commented Aug 1, 2021

mandre commented Aug 2, 2021

openshift-bot commented Aug 23, 2021

openshift-bot commented Aug 23, 2021

yboaron commented Aug 26, 2021

yboaron commented Aug 26, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-ci bot commented Aug 27, 2021 • edited

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 27, 2021

openshift-bot commented Aug 28, 2021

openshift-bot commented Aug 28, 2021

openshift-ci bot commented Aug 28, 2021

openshift-ci bot commented Aug 27, 2021 •

edited