Bug 1986757: Set timeoutSeconds for keepalived liveness probe #2703
Conversation
timeoutSeconds defaults to 1 second, but our liveness probe attempts to wait for 5 seconds. This seems to be causing frequent liveness probe timeouts in some environments which triggers unnecessary restarts. This patch sets timeoutSeconds to 5 to match the expectations of the probe.
openshift-ci
bot
added
bugzilla/severity-medium
|
@cybertron: This pull request references Bugzilla bug 1986757, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (vvoronko@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-ovirt |
openshift-ci
bot
requested review from
Gal-Zaidman,
jcpowermac,
mandre and
patrickdillon
|
/lgtm |
|
/retest |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/test e2e-metal-ipi |
|
All of the affected platforms are now passing. This is a pretty simple change that isn't platform-specific so I think it could probably go in (although it would be even better if someone from the remaining two platforms could chime in). |
openshift-ci
bot
added
the
do-not-merge/hold
There was a problem hiding this comment.
Adding an approval and also a hold to be removed by @cybertron once he feels it's ready and has necessary approvals.
/hold
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, Gal-Zaidman, kikisdeliveryservice, mandre, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test e2e-agnostic-upgrade |
1 similar comment
|
/test e2e-agnostic-upgrade |
|
The failing jobs all appear to be permafails and none of them even deploy the changed template. I think we just need to skip them. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: All pull requests linked via external trackers have merged: Bugzilla bug 1986757 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.8 |
|
@yboaron: new pull request created: #2741 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
timeoutSeconds defaults to 1 second, but our liveness probe attempts
to wait for 5 seconds. This seems to be causing frequent liveness
probe timeouts in some environments which triggers unnecessary
restarts.
This patch sets timeoutSeconds to 5 to match the expectations of
the probe.
- Description for the changelog
Fixed an issue with the keepalived liveness probe that could cause spurious timeouts.