Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1994277: delete the memory manager state file before the kubelet start #2718

Merged
merged 1 commit into from Aug 21, 2021
Merged

Bug 1994277: delete the memory manager state file before the kubelet start #2718

merged 1 commit into from Aug 21, 2021

Conversation

cynepco3hahue
Copy link
Contributor

@cynepco3hahue cynepco3hahue commented Aug 16, 2021 •
edited

Once you change the memory manager policy it requires removing the memory manager state file, otherwise, the kubelet will fail to restart. To avoid kubelet start failures during the change of the memory manager policy we can remove the state as PreStart condition under the systemd unit file.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

- What I did

- How to verify it

- Description for the changelog

Delete the memory manager state file before the kubelet start

Delete the memory manager state file before the kubelet start
55c749c 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@kikisdeliveryservice
Copy link
Contributor

@cynepco3hahue can you give us some background for this change?

@cynepco3hahue
Copy link
Contributor Author

@cynepco3hahue can you give us some background for this change?

Added more information under the description, please let me know if it is good enough. In general, the memory manager state file validation is the same as for the CPU manager, so we need to do similar steps to be sure that it will not prevent the kubelet restart.

@rphillips
Copy link
Contributor

Is there a BZ?

@cynepco3hahue cynepco3hahue changed the title Delete the memory manager state file before the kubelet start Bug 1994277: delete the memory manager state file before the kubelet start Aug 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

@cynepco3hahue: This pull request references Bugzilla bug 1994277, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

Bug 1994277: delete the memory manager state file before the kubelet start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 17, 2021
@openshift-ci openshift-ci bot requested a review from wabouhamad August 17, 2021 08:15
@cynepco3hahue
Copy link
Contributor Author

@rphillips I attached the BZ.

@cynepco3hahue
Copy link
Contributor Author

/retest

1 similar comment
@cynepco3hahue
Copy link
Contributor Author

/retest

wabouhamad
wabouhamad reviewed Aug 17, 2021
View reviewed changes
Copy link

@wabouhamad wabouhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@cynepco3hahue
Copy link
Contributor Author

/retest

@Tal-or Tal-or mentioned this pull request Aug 18, 2021
Merged
@rphillips
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cynepco3hahue, rphillips, wabouhamad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@cynepco3hahue
Copy link
Contributor Author

/retest

@rphillips
Copy link
Contributor

/skip
/retest-required

@cynepco3hahue
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@cynepco3hahue
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@ffromani
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@cynepco3hahue
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021 •
edited

@cynepco3hahue: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 55c749c link /test e2e-aws-workers-rhel7
ci/prow/okd-e2e-aws 55c749c link /test okd-e2e-aws
ci/prow/e2e-aws-techpreview-featuregate 55c749c link /test e2e-aws-techpreview-featuregate
ci/prow/e2e-aws-disruptive 55c749c link /test e2e-aws-disruptive
ci/prow/e2e-aws-single-node 55c749c link /test e2e-aws-single-node
ci/prow/e2e-aws-upgrade-single-node 55c749c link /test e2e-aws-upgrade-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3b4771a into openshift:master Aug 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@cynepco3hahue: All pull requests linked via external trackers have merged:

Bugzilla bug 1994277 has been moved to the MODIFIED state.

In response to this:

Bug 1994277: delete the memory manager state file before the kubelet start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wabouhamad wabouhamad wabouhamad left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@wabouhamad wabouhamad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cynepco3hahue @kikisdeliveryservice @rphillips @openshift-bot @ffromani @wabouhamad @openshift-merge-robot