[release-4.6] Bug 1989403: daemon: add check before updating kernelArgs #2720
Conversation
Also, make kargs variable and function name logical to avoid confusion. Cherry-pick of openshift#2349
|
@sinnykumari: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sinnykumari
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@sinnykumari: This pull request references Bugzilla bug 1989403, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@sinnykumari: This pull request references Bugzilla bug 1989403, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rioliu@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kikisdeliveryservice
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
an attempt to see if some of these option tests passes, although this PR doesn't impact these tests and is covered by e2e-gcp-op test. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@sinnykumari: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
deads2k
added
the
cherry-pick-approved
|
(patch manager) high bz, 0.5, upgrade bug |
|
@sinnykumari: All pull requests linked via external trackers have merged: Bugzilla bug 1989403 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also, make kargs variable and function name logical to
avoid confusion.
Manual cherry-pick of #2349