Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1980844: install/0000_90_machine-config-operator_01_prometheus-rules: Doc 95% for SystemMemoryExceedsReserved #2722

Merged
merged 1 commit into from Aug 24, 2021
Merged

Bug 1980844: install/0000_90_machine-config-operator_01_prometheus-rules: Doc 95% for SystemMemoryExceedsReserved #2722

merged 1 commit into from Aug 24, 2021

Conversation

wking
Copy link
Member

@wking wking commented Aug 19, 2021

Catching the message up with the logic change from 5148f16 (#2716).

@wking
install/0000_90_machine-config-operator_01_prometheus-rules: Doc 95% …
60ec2b7 
…for SystemMemoryExceedsReserved

Catching the message up with the logic change from 5148f16 (bump
SystemMemoryExceedsReservation alert threshold to 95%, 2021-08-16, openshift#2716).
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@wking: This pull request references Bugzilla bug 1980844, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

Bug 1980844: install/0000_90_machine-config-operator_01_prometheus-rules: Doc 95% for SystemMemoryExceedsReserved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Aug 19, 2021
Merged
@harche
Copy link
Contributor

harche commented Aug 19, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
sinnykumari
sinnykumari approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, sinnykumari, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

/skip

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

im just adding a hold for now since the e2e-upgrade is broken
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@kikisdeliveryservice
Copy link
Contributor

/test e2e-agnostic-upgrade

3 similar comments
@sinnykumari
Copy link
Contributor

/test e2e-agnostic-upgrade

@sdodson
Copy link
Member

sdodson commented Aug 23, 2021

/test e2e-agnostic-upgrade

@harche
Copy link
Contributor

harche commented Aug 24, 2021

/test e2e-agnostic-upgrade

@sinnykumari
Copy link
Contributor

To see if upgrade job is only broken on azure platform (currently being used by e2e-agnostic-upgrade)
/test e2e-gcp-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 60ec2b7 link /test e2e-metal-ipi
ci/prow/e2e-gcp-op-single-node 60ec2b7 link /test e2e-gcp-op-single-node
ci/prow/e2e-aws-techpreview-featuregate 60ec2b7 link /test e2e-aws-techpreview-featuregate
ci/prow/e2e-ovn-step-registry 60ec2b7 link /test e2e-ovn-step-registry
ci/prow/okd-e2e-aws 60ec2b7 link /test okd-e2e-aws
ci/prow/e2e-aws-single-node 60ec2b7 link /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel7 60ec2b7 link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-serial 60ec2b7 link /test e2e-aws-serial
ci/prow/e2e-vsphere-upgrade 60ec2b7 link /test e2e-vsphere-upgrade
ci/prow/e2e-aws-disruptive 60ec2b7 link /test e2e-aws-disruptive
ci/prow/e2e-aws-upgrade-single-node 60ec2b7 link /test e2e-aws-upgrade-single-node
ci/prow/e2e-gcp-upgrade 60ec2b7 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Contributor

e2e-agnostic-upgrade has succeeded, removing hold to get it merged.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit d5ad174 into openshift:master Aug 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@wking: All pull requests linked via external trackers have merged:

Bugzilla bug 1980844 has been moved to the MODIFIED state.

In response to this:

Bug 1980844: install/0000_90_machine-config-operator_01_prometheus-rules: Doc 95% for SystemMemoryExceedsReserved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@harche harche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wking @harche @openshift-bot @kikisdeliveryservice @sinnykumari @sdodson @openshift-merge-robot