[release-4.7] Bug 1995853: Gracefully shutdown taking around 6-7 mins (libvirt provider) #2727
Conversation
The machine-config-daemon gets stuck blocking SIGTERM on rebootless updatesbecause it only removes its SIGTERM protection when it reboots or when it encounters an error in the triggerUpdateWithmachineConfig-> update->performPostConfigChangeAction cycle. This changes the behavior such that it will remove the protection on a successful rebootless update and adds some logging messages so it's more clear when it starts and stops protecting itself.
|
@openshift-cherrypick-robot: Bugzilla bug 1965992 has been cloned as Bugzilla bug 1995853. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1995853, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@sinnykumari: This pull request references Bugzilla bug 1995853, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/skip |
|
/bugzilla refresh |
|
@knobunc: An error was encountered querying GitHub for users with public email (mnguyen@redhat.com) for bug 1995853 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knobunc
added
bugzilla/severity-urgent
|
/bugzilla refresh |
|
@tjungblu: This pull request references Bugzilla bug 1995853, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mike-nguyen can you please take a quick gander as well? I'll be happy to pull that in it for our customer urgently. |
|
This PR is waiting on patch manager approval now to get cherry-picked. |
|
@sinnykumari can a QE look into this please? 4.7 ci is already a bit unstable at the minute. |
I am not sure what you need right now from QE. QE will work on verify bug once the PR gets merged and new build is available in errata for testing. |
|
OK. Was verified in 4.8 and 4.9 #2631. |
tjungblu
added
the
cherry-pick-approved
|
/test e2e-aws |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Retrying, not sure why it is failing. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1995853 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2631
/assign jkyros